From: Christoph Hellwig <hch@lst.de>
To: Clay Mayers <Clay.Mayers@kioxia.com>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH V2 1/2] nvme: Include AEN CQE.DW1 in NVME_AEN uevents
Date: Tue, 25 Oct 2022 17:38:46 +0200 [thread overview]
Message-ID: <20221025153846.GA24661@lst.de> (raw)
In-Reply-To: <96244e61f9b94ed3aff59f3f14ecdca4@kioxia.com>
On Tue, Oct 18, 2022 at 08:12:59PM +0000, Clay Mayers wrote:
> What happens today is a warning is logged and the log page is left
> unread. The patch closes that gap allowing ZDC AENs to be enable
> and handled in user space for things like RocksDB's ZenFS. Kernel
> clients will also need a way to handle them, but can't that be a
> different patch series?
The problem is how the NVMe AENs work - the are raised and then the
AEN command completion is delivered and they are cleared by reading
the log page. But if we deliver them to userspace, we lose the pending
state of the AEN for the kernel. Right now that is not an issue,
but we lose all chance of ever making use of that information in
the kernel. So maybe the answer is to handle the AEN in the kernel,
read the changed zones log in the kernel, and then send an uevent
for all changes zones to userspace.
next prev parent reply other threads:[~2022-10-25 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 22:39 [PATCH V2 0/2] nvme: Support user mode processing of ZNS Zone Changed AEN clay.mayers
2022-09-29 22:39 ` [PATCH V2 1/2] nvme: Include AEN CQE.DW1 in NVME_AEN uevents clay.mayers
2022-10-17 13:23 ` Christoph Hellwig
2022-10-18 20:12 ` Clay Mayers
2022-10-25 15:38 ` Christoph Hellwig [this message]
2022-10-25 15:59 ` Sagi Grimberg
2022-10-29 0:47 ` Clay Mayers
2022-09-29 22:39 ` [PATCH V2 2/2] nvme: All AENs of type notify generate an NVME_AEN uevent clay.mayers
2022-10-04 1:48 ` [PATCH V2 0/2] nvme: Support user mode processing of ZNS Zone Changed AEN Chaitanya Kulkarni
2022-10-04 19:09 ` Clay Mayers
2022-10-07 4:59 ` Chaitanya Kulkarni
2022-10-06 11:33 ` Sagi Grimberg
2022-10-06 20:16 ` Clay Mayers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025153846.GA24661@lst.de \
--to=hch@lst.de \
--cc=Clay.Mayers@kioxia.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox