Re: [PATCH v7 01/23] net: Introduce direct data placement tcp offload

Jakub Kicinski
2022-10-31T23:48:01Z

On Mon, 31 Oct 2022 18:13:19 +0000 Shai Malin wrote:
> > Then there are stats.
>
> In the patch "net/mlx5e: NVMEoTCP, statistics" we introduced
> rx_nvmeotcp_* stats.
> We believe it should be collected by the device driver and not
> by the ULP layer.

I'm not sure I agree, but that's not the key point.
The key point is that we want the stats to come via a protocol specific
interface, and not have to be fished out of the ethtool -S goop. You
can still collect them in the driver, if we have any ULP-level stats at
any point we can add them to the same interface.