RE: [PATCH v7 04/23] Revert "nvme-tcp: remove the unused queue_size member in nvme_tcp_queue"

Shai Malin
2022-10-26T11:53:03Z

On Wed, 26 Oct 2022 at 12:02, Sagi Grimberg <sagi@grimberg.me> wrote:
> >> This reverts commit fb8745d040ef5b9080003325e56b91fefe1022bb.
> >>
> >> The newly added NVMeTCP offload requires the field
> >> nvme_tcp_queue->queue_size in the patch
> >> "nvme-tcp: Add DDP offload control path" in nvme_tcp_offload_socket().
> >> The queue size is part of struct ulp_ddp_config
> >> parameters.
> >
> > Please never do reverts if you just bring something back for an entirely
> > differenet reason.
>
> Agreed.

Sure.

>
> > And I think we need a really good justification of
> > why you have a code path that can get the queue struct and not the
> > controller, which really should not happen.
>
> What is wrong with just using either ctrl->sqsize/NVME_AQ_DEPTH based
> on the qid?

Thanks, we will use ctrl->sqsize.
No need to use NVME_AQ_DEPTH as the offload is used only with IO queues.