public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@meta.com>
To: <linux-nvme@lists.infradead.org>
Cc: <hch@lst.de>, <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	Daniel Wagner <dwagner@suse.de>,
	Alan Adamson <alan.adamson@oracle.com>
Subject: [PATCH] nvme: quiet user passthrough command errors
Date: Wed, 26 Oct 2022 10:07:15 -0700	[thread overview]
Message-ID: <20221026170715.2657664-1-kbusch@meta.com> (raw)

From: Keith Busch <kbusch@kernel.org>

The driver is spamming the kernel logs for entirely harmless errors from
user space submitting unsupported commmands. Just silence the errors.
The application has direct access to command status, so there's no need
to log these.

Cc: Daniel Wagner <dwagner@suse.de>
Cc: Alan Adamson <alan.adamson@oracle.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 686c55cb5d1a..da874172a31d 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1156,6 +1156,7 @@ int nvme_execute_passthru_rq(struct request *rq, u32 *effects)
 	struct nvme_ns *ns = rq->q->queuedata;
 
 	*effects = nvme_passthru_start(ctrl, ns, cmd->common.opcode);
+	rq->rq_flags |= RQF_QUIET;
 	return nvme_execute_rq(rq, false);
 }
 EXPORT_SYMBOL_NS_GPL(nvme_execute_passthru_rq, NVME_TARGET_PASSTHRU);
-- 
2.30.2



             reply	other threads:[~2022-10-26 17:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221026171201epcas5p1f6333717c7f12b5a8fe362cf09c5447d@epcas5p1.samsung.com>
2022-10-26 17:07 ` Keith Busch [this message]
2022-10-26 18:04   ` [PATCH] nvme: quiet user passthrough command errors Chaitanya Kulkarni
2022-10-26 18:08     ` Alan Adamson
2022-10-26 18:19     ` Keith Busch
2022-10-26 21:27   ` Alan Adamson
2022-10-27  5:41   ` Kanchan Joshi
2022-10-27 13:17     ` Jens Axboe
2022-10-27 15:00       ` Keith Busch
2022-10-27 16:40         ` Chaitanya Kulkarni
2022-10-27 13:14   ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026170715.2657664-1-kbusch@meta.com \
    --to=kbusch@meta.com \
    --cc=alan.adamson@oracle.com \
    --cc=dwagner@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox