From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
sagi@grimberg.me, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: implement the DEAC bit for the Write Zeroes command
Date: Tue, 1 Nov 2022 10:59:46 +0100 [thread overview]
Message-ID: <20221101095946.GB13058@lst.de> (raw)
In-Reply-To: <Y1/kw75JaNsnt1iy@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Oct 31, 2022 at 09:07:47AM -0600, Keith Busch wrote:
> Minor nit on the patch: I think seeing the dlfeat value as an enum would
> help.
The issue here is that the bit doesn't have a name in the NVMe spec,
so making up one would be a bit odd. But Mike is set out to eventually
name all the bits, and if that happens I'd be glad to add a name.
That's also an argument against the check if the lower flfeat bits
that Martin suggested, which shouldn't be needed but is otherwise
harmless: due to the lack of naming in dlfeat it would be really hard
to read..
next prev parent reply other threads:[~2022-11-01 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 16:29 [PATCH] nvme: implement the DEAC bit for the Write Zeroes command Christoph Hellwig
2022-10-31 9:01 ` Guixin Liu
2022-10-31 14:43 ` Pankaj Raghav
2022-10-31 14:54 ` Martin K. Petersen
2022-10-31 15:07 ` Keith Busch
2022-10-31 15:48 ` Martin K. Petersen
2022-11-01 9:58 ` Christoph Hellwig
2022-11-01 15:49 ` Martin K. Petersen
2022-11-04 7:06 ` Christoph Hellwig
2022-11-01 9:59 ` Christoph Hellwig [this message]
2022-11-02 10:46 ` Niklas Cassel
2022-11-02 15:56 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101095946.GB13058@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox