Re: [PATCH] nvme: implement the DEAC bit for the Write Zeroes command

Chaitanya Kulkarni
2022-11-02T15:56:23Z

On 10/30/22 09:29, Christoph Hellwig wrote:
> While the specification allows devices to either deallocate data
> or to actually write zeroes on any Write Zeroes command, many SSDs
> only do the sensible thing and deallocate data when the DEAC bit
> is specific. Set it when it is suppored and the caller doesn't

's/suppored/supported'

> explicitly opt out of deallocation.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
> BTW, I'm tempted to slap a
>
> Fixes: 6e02318eaea5 ("nvme: add support for the Write Zeroes command")
>
> onto this. While it doesn't fix the Write Zeroes support per se,
> it should help us with a lot of the devices timing out on Write Zeroes.
>

Indeed it doesn't fix 6e02318eaea5 but I think with appropriate
description it should help.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck