From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Uday Shankar <ushankar@purestorage.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH v2] nvme: scan sequentially only when list scan unsupported
Date: Wed, 9 Nov 2022 07:23:30 +0100 [thread overview]
Message-ID: <20221109062330.GC10528@lst.de> (raw)
In-Reply-To: <Y2rpIJ9lSJYnb+GG@kbusch-mbp.dhcp.thefacebook.com>
On Tue, Nov 08, 2022 at 04:41:20PM -0700, Keith Busch wrote:
> Looks fine, but I really don't look forward to finding out how many
> devices, if any, were secretly relying on this fallback.
I'm a little worried as well. Maybe we can whitelist a few status
codes as suggestions that a device might just be a broken. I.e.
"NVME_INVALID_FIELD | NVME_DNR" would very much be an indicator of tat.
Also Uday, the return value from nvme_scan_ns_list can and should be
dropped now.
next prev parent reply other threads:[~2022-11-09 6:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 19:54 [PATCH v2] nvme: scan sequentially only when list scan unsupported Uday Shankar
2022-11-08 2:30 ` Guixin Liu
2022-11-08 7:25 ` Guixin Liu
2022-11-08 23:38 ` Chaitanya Kulkarni
2022-11-08 23:41 ` Keith Busch
2022-11-09 6:23 ` Christoph Hellwig [this message]
2022-11-09 21:04 ` Uday Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109062330.GC10528@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox