From: Uday Shankar <ushankar@purestorage.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH v2] nvme: scan sequentially only when list scan unsupported
Date: Wed, 9 Nov 2022 14:04:05 -0700 [thread overview]
Message-ID: <20221109210405.GA2659347@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <20221109062330.GC10528@lst.de>
On Wed, Nov 09, 2022 at 07:23:30AM +0100, Christoph Hellwig wrote:
> On Tue, Nov 08, 2022 at 04:41:20PM -0700, Keith Busch wrote:
> > Looks fine, but I really don't look forward to finding out how many
> > devices, if any, were secretly relying on this fallback.
>
> I'm a little worried as well. Maybe we can whitelist a few status
> codes as suggestions that a device might just be a broken. I.e.
> "NVME_INVALID_FIELD | NVME_DNR" would very much be an indicator of tat.
Can we get away with just testing for the DNR bit? The practical goal of
this patch is to prevent fallback to sequential scan when the Identify
NS List command fails for transient reasons, and I think the error code
returned in such cases should not have DNR set.
> Also Uday, the return value from nvme_scan_ns_list can and should be
> dropped now.
We'll want to keep the return value if we go with the above suggestion.
prev parent reply other threads:[~2022-11-09 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 19:54 [PATCH v2] nvme: scan sequentially only when list scan unsupported Uday Shankar
2022-11-08 2:30 ` Guixin Liu
2022-11-08 7:25 ` Guixin Liu
2022-11-08 23:38 ` Chaitanya Kulkarni
2022-11-08 23:41 ` Keith Busch
2022-11-09 6:23 ` Christoph Hellwig
2022-11-09 21:04 ` Uday Shankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109210405.GA2659347@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox