From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 417C3C4332F for ; Tue, 15 Nov 2022 09:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J/ktI1wJzhYlhNUz3cJnDqK/RiKbDbZ3b7lIPZrI6I4=; b=F7ivSv+o1hNR/4Yoicf8W2o7bJ kZjZreS2U04n6VR4tSuWAhWffOE0LmgHxi+VCK93T14gIptlxuH98eVeQbz5pDZsrpT+WUf0mUvlY mkjW67wiretzTaOsYJXY1cSzpt+iCkiIIJJTf+ONFP0plg8gEhe0G8Ad7W3QuFmgZT4O7nC3NsSpz AsNdIXVx0RToiC2SWxcaGQ/f44In8fLT5tKxxSOmPFNAWVj6RlYXHcZO7fk36HbOheZFCNgrQ+DKT MwsO5yDKsMir0JtFuOLo10hdReMaOqknUENsz+r/3R77b5Y3T3ZEOeT+icPJxLTop0RMP/YIT8DBd J4w/pB6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ous1M-009EZZ-6Z; Tue, 15 Nov 2022 09:14:20 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ous1J-009EU4-6o for linux-nvme@lists.infradead.org; Tue, 15 Nov 2022 09:14:18 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 1999B68C4E; Tue, 15 Nov 2022 10:14:04 +0100 (CET) Date: Tue, 15 Nov 2022 10:14:03 +0100 From: Christoph Hellwig To: Mike Christie Cc: Christoph Hellwig , kbusch@kernel.org, axboe@fb.com, sagi@grimberg.me, martin.petersen@oracle.com, jejb@linux.ibm.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: Re: [PATCH 3/3] nvme: Convert NVMe errors to PT_STS errors Message-ID: <20221115091403.GA22594@lst.de> References: <20221109031106.201324-1-michael.christie@oracle.com> <20221109031106.201324-4-michael.christie@oracle.com> <20221109065338.GC11097@lst.de> <8adcb890-ec08-cc75-6e1a-2b8dabdcd640@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8adcb890-ec08-cc75-6e1a-2b8dabdcd640@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_011417_412691_F7E490D1 X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 11:20:07AM -0600, Mike Christie wrote: > >> + case NVME_SC_BAD_ATTRIBUTES: > >> + case NVME_SC_INVALID_OPCODE: > >> + case NVME_SC_INVALID_FIELD: > >> + case NVME_SC_INVALID_NS: > >> + sts = PR_STS_OP_INVALID; > >> + break; > > > > Second thoughts on these: shouldn't we just return negative Linux > > errnos here? > > I wasn't sure. I might have over thought it. > > I added the PR_STS error codes for those cases so a user could > distinguish if the command was sent to the device and it > reported it didn't support the command or the device determined it > had an invalid field set. But does it matter if the device or the kernel doesn't support them? The result for the users is very much the same.