Re: [PATCH] nvme: add re-authentication running concurrently with reset

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Nov 14, 2022 / 14:52, Sagi Grimberg wrote:
> when re-authentication with new host-key and/or ctrl-key there is an
> async work that is scheduled async. A controller reset should be mutual
> exclusive with the re-authentication work. Add a test that triggers
> re-authentication and immediately resets the controller.
> 
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

Thanks. I believe that this test case checks fix of a problem found during your
work on "nvme: fixes, cleanups and enhancements to the dhchap-auth host code".

I have some nit comments. Other than these, the patch looks good for me.

- Shellcheck have a couple of complaints:

  $ make check
  shellcheck -x -e SC2119 -f gcc check new common/* \
          tests/*/rc tests/*/[0-9]*[0-9]
  tests/nvme/046:87:20: note: Double quote to prevent globbing and word splitting. [SC2086]
  tests/nvme/046:93:20: note: Double quote to prevent globbing and word splitting. [SC2086]
  make: *** [Makefile:21: check] Error 1

- The test() function lists all local variables except "hostkey_file",
  "ctrlkey_file" and "nvvmedev". A bit better to declare those three also.

- It would be a bit better for linux-nvme readers to have subject prefix
  "[PATCH blktests]" to clarify it is not the patch for linux, but for blktests.

-- 
Shin'ichiro Kawasaki