Re: [PATCH] nvme: don't call blk_mq_{,un}quiesce_tagset when ctrl->tagset is NULL

Christoph Hellwig
2022-11-29T09:05:08Z

On Tue, Nov 22, 2022 at 01:31:54PM +0100, Christoph Hellwig wrote:
> This would be the queue_count version. I have to say I much prefer
> the tagset check, as it is self-documenting and matches what
> nvme_queue_scan, nvme_cancel_tagset and nvme_cancel_admin_tagset
> do.

So no comments so far. Unless I hear more feedback I'd prefer to
go with the ->tagset checks that matches what the other code is
doing and also is more readable.