From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDBD0C4332F for ; Tue, 22 Nov 2022 06:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ANtoH2f77TCbDm5lvuTKcWcA/dmWhUBOfYSwOfGWu+4=; b=jP6U54LiNPYY4cyefJ3wkA+RBS ulgITBcmQybXy7+b25dD7SlqgRUZIRz7mopXjnHP5nGQcInRSLGQN6F58XS1wVytqjCBfxHKc8wiR YOMDxs2BcJibSzfgEWtZeR9Pu3Q/DJOl6yxvFevR37LKWeQZoC+gvApp0sIAMSLQo1jymDAkj+y20 Tpe943PJpnrPRK6/YGx1FtJVwChA+D+yCKg+wKrlDpONPq9T1sNtSTAkPV/UJB+1gTFv6II4RBJcj EgraEl/kcWI6MQWmjHIBZKRFj350xSpa/cd42dA6wDSP6fEBKzbopUTPeXUcBK+6bweO4097z3Ajd k0ISaWeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxMSr-004rT2-AR; Tue, 22 Nov 2022 06:09:01 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxMSo-004rRi-Pv for linux-nvme@lists.infradead.org; Tue, 22 Nov 2022 06:09:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4754C68D05; Tue, 22 Nov 2022 07:08:55 +0100 (CET) Date: Tue, 22 Nov 2022 07:08:55 +0100 From: Christoph Hellwig To: Chao Leng Cc: Shakeel Butt , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Ming Lei , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Hannes Reinecke Subject: Re: [PATCH 14/14] nvme: use blk_mq_[un]quiesce_tagset Message-ID: <20221122060855.GA14111@lst.de> References: <20221101150050.3510-1-hch@lst.de> <20221101150050.3510-15-hch@lst.de> <20221121204450.6vyg6gixsz4unpaz@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_220859_032812_C7E4EC8F X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Nov 22, 2022 at 10:53:17AM +0800, Chao Leng wrote: >> This patch is causing the following crash at the boot and reverting it >> fixes the issue. This is next-20221121 kernel. > This patch can fix it. > https://lore.kernel.org/linux-nvme/20221116072711.1903536-1-hch@lst.de/ Yes, But I'm a little curious how it happened. Shakeel, do you have a genuine admin controller that does not have any I/O queues to start with, or did we have other setup time errors? Can youpost the full dmesg?