From: Christoph Hellwig <hch@lst.de>
To: Zhang Qilong <zhangqilong3@huawei.com>
Cc: sagi@grimberg.me, hare@suse.de, kbusch@kernel.org, hch@lst.de,
axboe@fb.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: fix memleak in nvme_ctrl_dhchap_secret_store()
Date: Tue, 29 Nov 2022 14:40:42 +0100 [thread overview]
Message-ID: <20221129134042.GB13668@lst.de> (raw)
In-Reply-To: <20221129084725.GB26082@lst.de>
On Tue, Nov 29, 2022 at 09:47:25AM +0100, Christoph Hellwig wrote:
> Thanks,
>
> applied to nvme-6.1.
And I had to fix it to actually pass all the correct paramters to
kmemdup, so it looks like this code wasn't even compile test.
Btw, how can nvme_ctrl_dhchap_secret_store work without any kind
of locking?
next prev parent reply other threads:[~2022-11-29 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 4:49 [PATCH v2] nvme: fix memleak in nvme_ctrl_dhchap_secret_store() Zhang Qilong
2022-11-22 9:44 ` Sagi Grimberg
2022-11-29 4:29 ` Chaitanya Kulkarni
2022-11-29 8:47 ` Christoph Hellwig
2022-11-29 13:40 ` Christoph Hellwig [this message]
2022-11-30 3:49 ` 答复: " zhangqilong
2022-11-30 8:37 ` Sagi Grimberg
2022-11-30 13:37 ` Christoph Hellwig
2022-12-01 1:57 ` 答复: " zhangqilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129134042.GB13668@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox