From: Joel Granados <j.granados@samsung.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"p.raghav@samsung.com" <p.raghav@samsung.com>,
"javier.gonz@samsung.com" <javier.gonz@samsung.com>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v5 1/1] nvme : Add ctrl id to allowed passthru commands
Date: Tue, 6 Dec 2022 08:41:46 +0100 [thread overview]
Message-ID: <20221206074146.h5aytkglqy76k54f@localhost> (raw)
In-Reply-To: <bbb80606-688d-f84e-6695-38127227d9f0@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Tue, Dec 06, 2022 at 04:25:59AM +0000, Chaitanya Kulkarni wrote:
> On 12/5/22 06:27, Joel Granados wrote:
> > Add NVME_ID_CNS_CS_CTRL and NVME_ID_CNS_CTRL to the nvme admin commands
> > that are allowed in unprivileged passthru. This will allow access to
> > attributes that are needed to effectively write to the char device in
> > passthru.
> >
>
> Perhaps mention what attributes are needed for clarity.
I'll add two examples of the attribute names to the commit message and
leave it at that. Hope that is OK, as having a list of all attributes
that might be used for a write operation will get long.
>
> Either way, looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
>
> -ck
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-12-06 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221205143143eucas1p2f5dd4e56ff5ab515fca60ecc0a10350c@eucas1p2.samsung.com>
2022-12-05 14:27 ` [PATCH v5 0/1] nvme : Add ctrl id to allowed passthru commands Joel Granados
2022-12-05 14:27 ` [PATCH v5 1/1] " Joel Granados
2022-12-05 15:35 ` Keith Busch
2022-12-06 8:28 ` Christoph Hellwig
2022-12-06 4:25 ` Chaitanya Kulkarni
2022-12-06 7:41 ` Joel Granados [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206074146.h5aytkglqy76k54f@localhost \
--to=j.granados@samsung.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox