From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Joel Granados <j.granados@samsung.com>,
hch@lst.de, chaitanyak@nvidia.com, sagi@grimberg.me,
p.raghav@samsung.com, javier.gonz@samsung.com,
joshi.k@samsung.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v5 1/1] nvme : Add ctrl id to allowed passthru commands
Date: Tue, 6 Dec 2022 09:28:21 +0100 [thread overview]
Message-ID: <20221206082821.GA8917@lst.de> (raw)
In-Reply-To: <Y44PtQ1uWtbBhx4X@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Dec 05, 2022 at 03:35:17PM +0000, Keith Busch wrote:
> I initially thought just open the entire nvme_identify_controller
> opcode, but this looks good to me.
But that's not an opcode. The opcode is identify, and then everything
else is multiplexed by the CNS value, even if the names of the
different CNS values sound like there might be another sub grouping.
next prev parent reply other threads:[~2022-12-06 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221205143143eucas1p2f5dd4e56ff5ab515fca60ecc0a10350c@eucas1p2.samsung.com>
2022-12-05 14:27 ` [PATCH v5 0/1] nvme : Add ctrl id to allowed passthru commands Joel Granados
2022-12-05 14:27 ` [PATCH v5 1/1] " Joel Granados
2022-12-05 15:35 ` Keith Busch
2022-12-06 8:28 ` Christoph Hellwig [this message]
2022-12-06 4:25 ` Chaitanya Kulkarni
2022-12-06 7:41 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206082821.GA8917@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=j.granados@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox