From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFFD2C3A5A7 for ; Tue, 6 Dec 2022 08:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=er/es5pbvgU5trYacz1ZP5aAPJHxXGeHrwZr7mVP6OM=; b=Wh0XOC+2Mp0a7c+3MYR9f5iLLN lLHWTzWC/gEWUVTVzdS7/eflSgYUHOPt5LwzKw3ngBX0EpgbWaCzNzEN+qOCIrZU7+5KIavNuwZ8R WGzkynqzLi0CG5+J69SkX2qurLuNpTmArp5Y8guTA6tya5sEYkFUHisatwKhxgspx5tylDmROzsFE klrxrHbB90uaTjrH3BADC7RLI7BmXm64JDj6NBJR/Tl/P2LkEGm3MekQh9s70YrUh7W6nO0RfGgEn bZ8bZsBjMLxKSQPU1toI5A0KDN1DNe+/Dla4JmhRwh6ZQnu6vc32t5iWzKoTz+sF/C0CraxXSJ80T VjUWlwUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2Tau-00597s-Tl; Tue, 06 Dec 2022 08:46:28 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2Tar-0058yz-WC for linux-nvme@lists.infradead.org; Tue, 06 Dec 2022 08:46:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4CAB968B05; Tue, 6 Dec 2022 09:46:21 +0100 (CET) Date: Tue, 6 Dec 2022 09:46:21 +0100 From: Christoph Hellwig To: Chao Leng Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , James Smart , Chaitanya Kulkarni , linux-nvme@lists.infradead.org Subject: Re: [PATCH 2/5] nvme: consolidate setting the tagset flags Message-ID: <20221206084621.GA9440@lst.de> References: <20221130174240.227616-1-hch@lst.de> <20221130174240.227616-3-hch@lst.de> <3b03aa7f-ea25-2973-3efc-900676f11220@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b03aa7f-ea25-2973-3efc-900676f11220@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_004626_197896_6F87A2A7 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Dec 06, 2022 at 04:43:45PM +0800, Chao Leng wrote: > tcp should set NVME_F_BLOCKING in ctrl->ops->flags, I did not see that in this patch. > Did I miss something? No, I missed that I got lost during my rebase.