From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 6/7] nvme: also return I/O command effects from nvme_command_effects
Date: Wed, 14 Dec 2022 08:58:03 +0100 [thread overview]
Message-ID: <20221214075803.GA4250@lst.de> (raw)
In-Reply-To: <Y5jQF51E+/vH/5Cv@kbusch-mbp>
On Tue, Dec 13, 2022 at 12:18:47PM -0700, Keith Busch wrote:
> + if (!ctrl->effects) {
> + if (id->lpa & NVME_CTRL_LPA_CMD_EFFECTS_LOG) {
> + ret = nvme_get_effects_log(ctrl, NVME_CSI_NVM,
> + &ctrl->effects);
> + if (ret < 0)
> + goto out_free;
> + } else {
> + ctrl->effects = kzalloc(sizeof(*ctrl->effects),
> + GFP_KERNEL);
> + if (!ctrl->effects) {
> + ret = -ENOMEM;
> + goto out_free;
> + }
> + }
> + nvme_init_known_nvm_effects(ctrl);
I'd probably move this entire block into a helper, but otherwise
this looks reasonable.
next prev parent reply other threads:[~2022-12-14 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 16:24 only allow unprivileged passthrough for commands without effects Christoph Hellwig
2022-12-13 16:24 ` [PATCH 1/7] nvmet: use NVME_CMD_EFFECTS_CSUPP instead of open coding it Christoph Hellwig
2022-12-14 4:46 ` Chaitanya Kulkarni
2022-12-13 16:24 ` [PATCH 2/7] nvmet: set the LBCC bit for commands that modify data Christoph Hellwig
2022-12-14 4:47 ` Chaitanya Kulkarni
2022-12-13 16:24 ` [PATCH 3/7] nvmet: allow async passthrough of commands that change logical block contents Christoph Hellwig
2022-12-14 4:52 ` Chaitanya Kulkarni
2022-12-14 7:59 ` Christoph Hellwig
2022-12-13 16:24 ` [PATCH 4/7] nvme: remove nvme_execute_passthru_rq Christoph Hellwig
2022-12-14 4:54 ` Chaitanya Kulkarni
2022-12-13 16:24 ` [PATCH 5/7] nvme: only return actual effects from nvme_command_effects Christoph Hellwig
2022-12-13 16:24 ` [PATCH 6/7] nvme: also return I/O command " Christoph Hellwig
2022-12-13 17:53 ` Keith Busch
2022-12-13 18:54 ` Christoph Hellwig
2022-12-13 19:18 ` Keith Busch
2022-12-14 7:58 ` Christoph Hellwig [this message]
2022-12-13 16:24 ` [PATCH 7/7] nvme: don't allow unprivileged passthrough of commands that have effects Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214075803.GA4250@lst.de \
--to=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox