From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1CE9C4332F for ; Thu, 15 Dec 2022 08:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1zwzRBWcGALWvLQjR8I4ZJsvjBDkDfpT6FaOFMPyqDE=; b=25JCAUDe20sAr8t0Y3xuL8PGZv BNplDcniYFCRHvFc7Qnl/CfMLfl5+1QnxEV0WP5hhmXdDyATqC5yzawZpni5H3Zoip0ubQTJjjXR5 BXYNIpzrxY2q58fR71fYBUfOQydEG2iHZ4cvbyqIBNtfzMqJpP0tLorIG6WPqYl46NNIqeg6dYee2 BWCXjmvxfGglhfZNuTSuhrwz/cZVqDVY6VcZxhseqgtvYGG1ELlWfqPXMIUK4/elbL2w9lXBx6Z3L 51T5gCZyTold+N5SH/3BjnwPiD+ldvT+S8Ja0qO0xbG8dIzF1yItR+en+6BPzgWqBWHelDPFDrTWu LhRLjP2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5jkd-007m4S-4q; Thu, 15 Dec 2022 08:37:59 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5jka-007m1Z-7p for linux-nvme@lists.infradead.org; Thu, 15 Dec 2022 08:37:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2EFDD68AA6; Thu, 15 Dec 2022 09:37:52 +0100 (CET) Date: Thu, 15 Dec 2022 09:37:51 +0100 From: Christoph Hellwig To: Kanchan Joshi Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org Subject: Re: [PATCH 9/9] nvme: don't allow unprivileged passthrough of commands that have effects Message-ID: <20221215083751.GA4367@lst.de> References: <20221214161347.764071-1-hch@lst.de> <20221214161347.764071-10-hch@lst.de> <20221215071405.GA27656@test-zns> <20221215081829.GA3816@lst.de> <20221215082410.GB27656@test-zns> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221215082410.GB27656@test-zns> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221215_003756_456894_16964068 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Dec 15, 2022 at 01:54:10PM +0530, Kanchan Joshi wrote: > But that patch still takes NVME_CMD_EFFECTS_CSUPP into account while > returning effects. It should be removed from there, and we need nothing > else here. Ooops, indeed. I accidentally broke that again.