From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-pci: place chain addresses in iod
Date: Wed, 21 Dec 2022 09:16:47 +0100 [thread overview]
Message-ID: <20221221081647.GA23377@lst.de> (raw)
In-Reply-To: <20221220182131.465092-1-kbusch@meta.com>
On Tue, Dec 20, 2022 at 10:21:31AM -0800, Keith Busch wrote:
> -#define NVME_MAX_KB_SZ 4096
> -#define NVME_MAX_SEGS 127
> +#define NVME_MAX_KB_SZ 8192
> +#define NVME_MAX_SEGS 128
> +#define NVME_MAX_CHAINS 5
NVME_MAX_CHAINS sounds a bit odd. Maybe MAX_ALLOCATIONS to match
the nr_allocations field?
>
> static int use_threaded_interrupts;
> module_param(use_threaded_interrupts, int, 0444);
> @@ -232,6 +233,7 @@ struct nvme_iod {
> dma_addr_t first_dma;
> dma_addr_t meta_dma;
> struct sg_table sgt;
> + void *list[NVME_MAX_CHAINS];
I think this should a union nvme_data_ptr * so that we have some typing
information.
next prev parent reply other threads:[~2022-12-21 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 18:21 [PATCH] nvme-pci: place chain addresses in iod Keith Busch
2022-12-21 8:16 ` Christoph Hellwig [this message]
2022-12-25 9:53 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221081647.GA23377@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox