From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 5/6] nvme: also return I/O command effects from nvme_command_effects
Date: Thu, 22 Dec 2022 09:57:37 +0100 [thread overview]
Message-ID: <20221222085737.GA13174@lst.de> (raw)
In-Reply-To: <Y6N913AdRwkbyuAD@kbusch-mbp.dhcp.thefacebook.com>
On Wed, Dec 21, 2022 at 02:42:47PM -0700, Keith Busch wrote:
> Just noticed we need to mask out the CSE value for IO commands in case
> some crazy controller sets it. If the driver were to see that value as
> non-zero, it will freeze the IO queue the ioctl requires to to submit
> its own IO request.
I'd rather reject passthrough of I/O commands with that effect
entirely, does that sound reasonable?
next prev parent reply other threads:[~2022-12-22 8:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221221145321epcas5p4ff234021b074bf0a513d1cb233135656@epcas5p4.samsung.com>
2022-12-21 10:10 ` only allow unprivileged passthrough for commands without effects v3 Christoph Hellwig
2022-12-21 10:10 ` [PATCH 1/6] nvme: fix the NVME_CMD_EFFECTS_CSE_MASK definition Christoph Hellwig
2022-12-21 10:10 ` [PATCH 2/6] nvmet: use NVME_CMD_EFFECTS_CSUPP instead of open coding it Christoph Hellwig
2022-12-21 10:10 ` [PATCH 3/6] nvmet: set the LBCC bit for commands that modify data Christoph Hellwig
2022-12-21 10:10 ` [PATCH 4/6] nvmet: don't defer passthrough commands with trivial effects to the workqueue Christoph Hellwig
2022-12-21 10:10 ` [PATCH 5/6] nvme: also return I/O command effects from nvme_command_effects Christoph Hellwig
2022-12-21 21:42 ` Keith Busch
2022-12-22 8:57 ` Christoph Hellwig [this message]
2022-12-22 15:38 ` Keith Busch
2022-12-23 7:14 ` Christoph Hellwig
2022-12-21 10:10 ` [PATCH 6/6] nvme: consult the CSE log page for unprivileged passthrough Christoph Hellwig
2022-12-22 8:19 ` only allow unprivileged passthrough for commands without effects v3 Kanchan Joshi
2022-12-23 7:45 ` Christoph Hellwig
2022-12-23 13:28 ` Kanchan Joshi
2022-12-23 14:04 ` Christoph Hellwig
2022-12-23 7:18 only allow unprivileged passthrough for commands without effects v4 Christoph Hellwig
2022-12-23 7:18 ` [PATCH 5/6] nvme: also return I/O command effects from nvme_command_effects Christoph Hellwig
2022-12-25 10:26 ` Sagi Grimberg
2022-12-27 16:57 ` Christoph Hellwig
2022-12-28 13:49 ` Sagi Grimberg
2022-12-28 15:12 ` Christoph Hellwig
2022-12-29 5:35 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222085737.GA13174@lst.de \
--to=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox