From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
Hugh Dickins <hughd@google.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/4] nvme-pci: update sqsize when adjusting the queue depth
Date: Wed, 28 Dec 2022 17:10:50 +0100 [thread overview]
Message-ID: <20221228161050.GA849@lst.de> (raw)
In-Reply-To: <f0d3c027-d793-8266-7c69-30a85f884b23@grimberg.me>
On Sun, Dec 25, 2022 at 01:19:43PM +0200, Sagi Grimberg wrote:
> But if you want to patches 1+2 to be taken before 3+4, I'd make sqsize
> to be a 0's based value of q_depth after we subtract one entry for queue
> wraparound. So others would not get affected from patches 1+2. Then in
> one batch make all assignments to sqsize 1's based like in patch 3 and
> change nvme_alloc_io_tagset at the same time.
1 doe not make any difference in the 0s based vs not values,
they just reduce the queue size by 1 intentionally.
next prev parent reply other threads:[~2022-12-28 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 10:32 fix nvme sqsize on off regression Christoph Hellwig
2022-12-25 10:32 ` [PATCH 1/4] nvme: fix setting the queue depth in nvme_alloc_io_tag_set Christoph Hellwig
2022-12-25 10:51 ` Sagi Grimberg
2022-12-25 10:53 ` Sagi Grimberg
2022-12-28 16:11 ` Christoph Hellwig
2022-12-25 21:15 ` Hugh Dickins
2022-12-25 10:32 ` [PATCH 2/4] nvme-pci: update sqsize when adjusting the queue depth Christoph Hellwig
2022-12-25 11:19 ` Sagi Grimberg
2022-12-28 16:10 ` Christoph Hellwig [this message]
2022-12-29 12:07 ` Sagi Grimberg
2022-12-29 16:34 ` Keith Busch
2023-01-02 9:39 ` Sagi Grimberg
2023-01-03 16:45 ` Keith Busch
2022-12-25 21:21 ` Hugh Dickins
2022-12-25 10:32 ` [PATCH 3/4] nvme: store the actual queue size in ctrl->sqsize Christoph Hellwig
2022-12-25 11:09 ` Sagi Grimberg
2022-12-28 17:02 ` Keith Busch
2022-12-25 10:32 ` [PATCH 4/4] nvme-pci: remove the dev->q_depth field Christoph Hellwig
2022-12-25 11:19 ` Sagi Grimberg
2022-12-26 19:11 ` (subset) fix nvme sqsize on off regression Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228161050.GA849@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=hughd@google.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox