public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/4] nvme: fix setting the queue depth in nvme_alloc_io_tag_set
Date: Wed, 28 Dec 2022 17:11:21 +0100	[thread overview]
Message-ID: <20221228161121.GB849@lst.de> (raw)
In-Reply-To: <4f1f6a12-bf9d-4118-23e9-6d20a3d8a265@grimberg.me>

On Sun, Dec 25, 2022 at 12:53:38PM +0200, Sagi Grimberg wrote:
> But this means that fabrics drivers automatically get 1 less queue entry? 
> with this patch alone?

Yes.  And also with the entire series.


  reply	other threads:[~2022-12-28 16:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 10:32 fix nvme sqsize on off regression Christoph Hellwig
2022-12-25 10:32 ` [PATCH 1/4] nvme: fix setting the queue depth in nvme_alloc_io_tag_set Christoph Hellwig
2022-12-25 10:51   ` Sagi Grimberg
2022-12-25 10:53     ` Sagi Grimberg
2022-12-28 16:11       ` Christoph Hellwig [this message]
2022-12-25 21:15   ` Hugh Dickins
2022-12-25 10:32 ` [PATCH 2/4] nvme-pci: update sqsize when adjusting the queue depth Christoph Hellwig
2022-12-25 11:19   ` Sagi Grimberg
2022-12-28 16:10     ` Christoph Hellwig
2022-12-29 12:07       ` Sagi Grimberg
2022-12-29 16:34         ` Keith Busch
2023-01-02  9:39           ` Sagi Grimberg
2023-01-03 16:45             ` Keith Busch
2022-12-25 21:21   ` Hugh Dickins
2022-12-25 10:32 ` [PATCH 3/4] nvme: store the actual queue size in ctrl->sqsize Christoph Hellwig
2022-12-25 11:09   ` Sagi Grimberg
2022-12-28 17:02   ` Keith Busch
2022-12-25 10:32 ` [PATCH 4/4] nvme-pci: remove the dev->q_depth field Christoph Hellwig
2022-12-25 11:19   ` Sagi Grimberg
2022-12-26 19:11 ` (subset) fix nvme sqsize on off regression Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221228161121.GB849@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=hughd@google.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox