From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 589E5C4332F for ; Thu, 29 Dec 2022 18:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=usORqHciyFUalESiER55B7VFdgT4QAkx64KL27S0Gjs=; b=C+Qh6gRzJPAt7V hRDo4iFbIyStAcpE/ogAN/qHawXlIKVwb6pRo27MOqHggHNZ24HqHykxXGmKZjQ3oay1vJR1FkwhS y9aqKxuvEXhHPUETUNJ0rc9i0p2AVta3uFE4hIKpinBuIV03w8XhSUUYvc0Ut2LKoTgqg9IO7Wuhq z1wr0wcuJtGQ72EX1kvyqz9WIX4YQTlSiSEy2u3eJic6LTkXTgwjqalwpWcRK2yOFw38XauMltGQD yg7KEbnhIbOHHYVSXfvoyGjPdocsN3mkdvZM7rkavrIIDP7VBsV/SX6L3GUerUn8sqU+4oVP0a6S0 m5X7kAb3j5KZqftQXgSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAxPS-000fxw-Ca; Thu, 29 Dec 2022 18:13:42 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAxPP-000fvE-2Y for linux-nvme@lists.infradead.org; Thu, 29 Dec 2022 18:13:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 904FEB818ED; Thu, 29 Dec 2022 18:13:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 304B2C433D2; Thu, 29 Dec 2022 18:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672337616; bh=usORqHciyFUalESiER55B7VFdgT4QAkx64KL27S0Gjs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=oOle2ajE2r1i8AIwwtR4Xcv8pq8zt1WzFElaAb9R+2zB2NMsYC3M2vMAT6LU19EvA 8GOb1NnBQEyGmafBrxNaPr5hQx8U0xGqwX5F3EwZEZnNkJpdetmeZ3ZVhf6LGJIY4r PlrrngObTMT2ad4b2jxY5Jmh6WQKdiCWECga8eP6JukGyuG/ap+YTaOJtua0iMMdBk z1oi6asC60n5CC4U+CfwSZF40Abl2Jpbl6uGYv3hNekZrZSb9FNIxQNqLuR1VGNOla IYTuW/xMIXCmrF21qEijQODtXr9gGCGQrAavV9cbF3TD8Wt1IYtp7P32CNFEiG4uQ8 yyAb74VeWQudA== Date: Thu, 29 Dec 2022 12:13:34 -0600 From: Bjorn Helgaas To: Shinichiro Kawasaki Cc: Chaitanya Kulkarni , Yi Zhang , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-scsi@vger.kernel.org" , "mstowe@redhat.com" , "linux-pci@vger.kernel.org" , Xiao Yang , Keith Busch Subject: Re: blktests failures with v5.19-rc1 Message-ID: <20221229181334.GA616694@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221219112703.rlqdo33ncgmuowfm@shindev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_101339_694994_120AE278 X-CRM114-Status: GOOD ( 10.43 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Dec 19, 2022 at 11:27:03AM +0000, Shinichiro Kawasaki wrote: > Bjorn, FYI. This lockdep warning disappeared with kernel version > v6.1. I bisected and found the commit 2d7f9f8c1815 ("kernfs: Improve > kernfs_drain() and always call on removal.") avoided the issue. This > commit touches kernfs_drain() and __kernfs_remove(), and modifies > the condition to lock kernfs_rwsem. I think it explains why the > lockdep disappeared. No longer need to work on this issue :) Thanks for following up on this! Bjorn