Re: [PATCH 1/9] nvme-apple: fix controller shutdown in apple_nvme_disable

Eric Curtin
2022-12-06T10:39:35Z

On Tue, 29 Nov 2022 at 13:29, Christoph Hellwig <hch@lst.de> wrote:
>
> nvme_shutdown_ctrl already shuts the controller down, there is no
> need to also call nvme_disable_ctrl for the shutdown case.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Eric Curtin <ecurtin@redhat.com>

> ---
> drivers/nvme/host/apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
> index 94ef797e8b4a5f..56d9e9be945b76 100644
> --- a/drivers/nvme/host/apple.c
> +++ b/drivers/nvme/host/apple.c
> @@ -831,7 +831,8 @@ static void apple_nvme_disable(struct apple_nvme *anv, bool shutdown)
>
> if (shutdown)
> nvme_shutdown_ctrl(&anv->ctrl);
> - nvme_disable_ctrl(&anv->ctrl);
> + else
> + nvme_disable_ctrl(&anv->ctrl);
> }
>
> WRITE_ONCE(anv->ioq.enabled, false);
> --
> 2.30.2
>
>