Re: [PATCH 3/9] nvme: merge nvme_shutdown_ctrl into nvme_disable_ctrl

Hector Martin
2022-11-29T15:44:57Z

On 29/11/2022 22.22, Christoph Hellwig wrote:
> Many of the callers decide which one to use based on a bool argument and
> there is at least some code to be shared, so merge these two. Also
> move a comment specific to a single callsite to that callsite.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/host/apple.c | 5 +----
> drivers/nvme/host/core.c | 33 ++++++++++-----------------------
> drivers/nvme/host/fc.c | 2 +-
> drivers/nvme/host/nvme.h | 3 +--
> drivers/nvme/host/pci.c | 15 +++++++++------
> drivers/nvme/host/rdma.c | 5 +----
> drivers/nvme/host/tcp.c | 5 +----
> drivers/nvme/target/loop.c | 2 +-
> 8 files changed, 25 insertions(+), 45 deletions(-)
>

For the Apple and core bits:

Reviewed-by: Hector Martin <marcan@marcan.st>

- Hector