public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Kanchan Joshi <joshi.k@samsung.com>
To: "Belanger, Martin" <Martin.Belanger@dell.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>,
	"smith, erik" <Erik.Smith@dell.com>,
	"Ghalam, Joe" <Joe.Ghalam@dell.com>,
	"Hayes, Stuart" <Stuart.Hayes@dell.com>,
	"White, Joseph L" <Joseph.L.White@dell.com>,
	"Glimcher, Boris" <Boris.Glimcher@dell.com>,
	axboe@kernel.dk
Subject: Re: nvme-fabrics: devices are uninterruptable
Date: Thu, 12 Jan 2023 11:06:55 +0530	[thread overview]
Message-ID: <20230112053655.GA743@green5> (raw)
In-Reply-To: <BLAPR19MB453154491C6DE9CB7C2A310BF2FC9@BLAPR19MB4531.namprd19.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

On Wed, Jan 11, 2023 at 02:37:58PM +0000, Belanger, Martin wrote:
>POSIX.1 specifies that certain functions such as read() or write() can act as cancellation points.
>
>Ref: https://pubs.opengroup.org/onlinepubs/000095399/functions/xsh_chap02_09.html#tag_02_09_05_02

Not exactly related to the original question, but I hear the
cancellation requirement for passthrough too.

And it seems feasible as io_uring provides cancellation interface
(IORING_OP_ASYNC_CANCEL) to user-space.
It is only at io_uring level, and does not percolate down to lower
layers (as we don't have an interface).
Will it make sense to grow such interface for uring_cmd. Either
a new file-op ->uring_cmd_cancel or existing ->uring_cmd with new
cancel-flag. 
Not sure if ublk too needs it, but NVMe can support this (new op/flag)
cancellation by issuing abort-command to the device.

Down in nvme, we would need command-id/queue-id to issue abort command,
and that maybe tricky to store (although it is something we do for
iopoll). Maybe I can figure something out while cooking up a RFC.

But first things first, 
Christoph, Jens: does this sound reasonable?

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2023-01-12  5:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230111144340epcas5p3940d3fbf8bd19771bf1fb55ba56ecf95@epcas5p3.samsung.com>
2023-01-11 14:37 ` nvme-fabrics: devices are uninterruptable Belanger, Martin
2023-01-12  5:36   ` Kanchan Joshi [this message]
2023-01-12 10:38     ` Hannes Reinecke
2023-01-13 11:26   ` Martin Wilck
2023-01-13 16:58     ` Belanger, Martin
2023-01-17 10:51   ` Christoph Hellwig
2023-01-17 15:28     ` Belanger, Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230112053655.GA743@green5 \
    --to=joshi.k@samsung.com \
    --cc=Boris.Glimcher@dell.com \
    --cc=Erik.Smith@dell.com \
    --cc=Joe.Ghalam@dell.com \
    --cc=Joseph.L.White@dell.com \
    --cc=Martin.Belanger@dell.com \
    --cc=Stuart.Hayes@dell.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox