From: Christoph Hellwig <hch@lst.de>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: regression on aarch64? panic on boot
Date: Tue, 17 Jan 2023 06:58:19 +0100 [thread overview]
Message-ID: <20230117055819.GB13795@lst.de> (raw)
In-Reply-To: <Y8XINx8fpGPKudW6@cormorant.local>
On Mon, Jan 16, 2023 at 10:57:11PM +0100, Klaus Jensen wrote:
> Hi,
>
> I'm getting panics when booting from a QEMU hw/nvme device on an aarch64
> guest in roughly 20% of boots on v6.2-rc4. Example panic below.
This smells like your setup somehow doesn't wait for async driver
probe. Does the hack below work around it?
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index b13baccedb4a95..f47e19c701d520 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3508,7 +3508,6 @@ static struct pci_driver nvme_driver = {
.remove = nvme_remove,
.shutdown = nvme_shutdown,
.driver = {
- .probe_type = PROBE_PREFER_ASYNCHRONOUS,
#ifdef CONFIG_PM_SLEEP
.pm = &nvme_dev_pm_ops,
#endif
next prev parent reply other threads:[~2023-01-17 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 21:57 regression on aarch64? panic on boot Klaus Jensen
2023-01-17 5:58 ` Christoph Hellwig [this message]
2023-01-17 6:31 ` Klaus Jensen
2023-01-17 6:37 ` Christoph Hellwig
2023-01-17 6:39 ` Klaus Jensen
2023-01-17 12:11 ` Martin Wilck
2023-01-19 8:29 ` Klaus Jensen
2023-01-19 16:48 ` Keith Busch
2023-01-24 17:11 ` Ville Syrjälä
2023-01-19 13:10 ` Linux kernel regression tracking (#adding)
2023-01-27 11:11 ` Linux kernel regression tracking (#update)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117055819.GB13795@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox