Re: [PATCH v2 1/2] nvme-apple: Reset controller during shutdown

Christoph Hellwig
2023-01-18T05:25:19Z

On Tue, Jan 17, 2023 at 07:25:00PM +0100, Janne Grunau wrote:
> + /*
> + * Always reset the NVMe controller on shutdown. The reset is
> + * required to shutdown the co-processor cleanly.
> + */

Hmm. This comment doesn't seem to match the discussion we had last
week. Which would be:

/*
* NVMe requires a reset before setting up a controller to
* ensure it is in a clean state. For NVMe PCIe this is
* done in the setup path to be able to deal with controllers
* in any kind of state. For for Apple devices, the firmware
* will not be available at that time and the reset will
* time out. Thus reset after shutting the NVMe controller
* down and before shutting the firmware down.
*/