From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F68BC05027 for ; Thu, 26 Jan 2023 16:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w0J4LimSn8ZUbTM5j1NedghnIFosV0mMEZMKi+xnnuo=; b=3Ip8dTp1/A/3J+NMsPlX+OtKcH XUzcPkAdsN9eYtedxae7iee9F+gM68kkuIynHsd3DiyFZ0BmRypKsvrnlS1DjsRqnv5ZD7mht/OUx Ae+g7HnWBcFS79g4b0FmSDcKwx5UkvVCkAAIU5G8V2sN9A3Nva7jrfW3WxKoO1uAAprwugaAYbUCO EbgescoYkNLBVayWkjixe/BAhB6jrJL/p79EPdtpxsB2Ky3nHJ/DIEErIpknNyAIB7H1ervXjkXB5 0uv+3jSDuQ7KsrEgZCkdAJukHBf15XoYoRe6fhADR0N9oQDzysYYFDzP4YmbXWxLJ6Lkpds9WRH9I qOKHVtGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL51U-00Bjao-Uk; Thu, 26 Jan 2023 16:22:49 +0000 Received: from mail-bn8nam04on2060.outbound.protection.outlook.com ([40.107.100.60] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL513-00BjOG-UI for linux-nvme@lists.infradead.org; Thu, 26 Jan 2023 16:22:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1c6Vi8iJMg9jHNfHZV4v3OG1tIBYWIM8FMiEaPJr88VG+vMsRR1kZ5SL6EtIJg40nsSuc7BJWUbutAGxccMYrqjxBzkxcJjgAXPJfiXseTA0oLbSX6CF8VSuqJOknBsrCHhY9A2156CQIv7mfaPm8DO+q5BjVvnlKCP2UMm1mRn+Casl41ktb4Re6HWDPtKCIwt0jU86G6fjwjxttO7HhpkKkbJ79CKupLymg11ALE8uRpLFdCjBHo+6mDbDTOQZ5f8sj9oonQ4W3bXhGHR/GFsfF5/k6MhRwnRmUwlrA1TclC6UkLAw2WPXLzReFn9mkNuIvzfLvmZ6ib2Uf+0TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w0J4LimSn8ZUbTM5j1NedghnIFosV0mMEZMKi+xnnuo=; b=Xc6PqryUFGaOpRlo5CpdDVAcqKCtr36kDmObx1hgK+XQpWwE0jw1b7DJur6fPEWn3ZdJ3Fg1kiUfREDgVub5hHoA9I624VkH9/f3yGKlEV0aqFynDof0FFg+EwoTfHakwWxkirIzcg49IbZ5rjW3b+YSP4rWZTzTSDfjNmACunDPouHqKnO8De1tHII7fYBm3ECQ/tYIOBzGRV32dAL8ebzW0ShAJs9F8YX0DbEDEMtbQfPK4hqgT1vk6CVwKKuWaIMNsAqWDnPV/Qc0qjm6KVzZKANbapoMYg9zzFN5v9vpSHdfNUgvFdd1B8o1NTl2hUBHhWN8doscd+GJfDasqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0J4LimSn8ZUbTM5j1NedghnIFosV0mMEZMKi+xnnuo=; b=eMFHlhBDmChqMrwdlWyBceSm1E9E67h5t4hUtFD3kpJjqK346FktHtkV/o23IQUIObbVMIct5ioWf6gWRGdosp2cT8AGJ9uSl7DtyzUbQBkcKVhe7O2lMZypjlCaxl5+EPuoMcNi6npOkzHzGvTSYp3b8jWdylwpkd4VR7Xuy06rLFY1s6cPuGGgicJ+EyFBSgRGVFiL/1xzxC22TWsnfMF54Txiy2cmE2DgPeKRvgRKoMkg1a+nVuBtBbrZol38wgklhzqcFAR4Hy4opOtu/jKTDwH7cyjEDs5GNxR6Dp05FoYIcVUhgmMhbIW6MD8wCtaZrPLHXA0rYh0377VurQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) by SJ0PR12MB5422.namprd12.prod.outlook.com (2603:10b6:a03:3ac::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 16:22:18 +0000 Received: from SJ1PR12MB6075.namprd12.prod.outlook.com ([fe80::9fd9:dadc:4d8a:2d84]) by SJ1PR12MB6075.namprd12.prod.outlook.com ([fe80::9fd9:dadc:4d8a:2d84%6]) with mapi id 15.20.6043.022; Thu, 26 Jan 2023 16:22:18 +0000 From: Aurelien Aptel To: linux-nvme@lists.infradead.org, netdev@vger.kernel.org, sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com, chaitanyak@nvidia.com, davem@davemloft.net, kuba@kernel.org, Alexander Viro Cc: Aurelien Aptel , aurelien.aptel@gmail.com, smalin@nvidia.com, malin1024@gmail.com, ogerlitz@nvidia.com, yorayz@nvidia.com, borisp@nvidia.com Subject: [PATCH v10 05/25] iov_iter: skip copy if src == dst for direct data placement Date: Thu, 26 Jan 2023 18:21:16 +0200 Message-Id: <20230126162136.13003-6-aaptel@nvidia.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230126162136.13003-1-aaptel@nvidia.com> References: <20230126162136.13003-1-aaptel@nvidia.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0215.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::35) To SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR12MB6075:EE_|SJ0PR12MB5422:EE_ X-MS-Office365-Filtering-Correlation-Id: 21b194b4-7726-45c0-61e2-08daffb97ebd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3JuX/j8SOMXP5XgyYMOUOV6rRqPCiAN/bM6EPdt3GPWKi0re3x9hXHFKhYf/AOEp8JIDWjt7QmoDohwR6Ateky59HagNJWT9hm/h/tJ9afboeqNnB2LAZ+nEcFmSg6OrZ819eRRxxMWIxA+EkwUkDSftpHqzgqaaLeGyg9wM4chvRjGeDBMoGzaI3Dl6svzCd8PmmxkFVlXWNGdwMFldu6KjbP/bLtuzVbiBT5tBufUgiUHDw1XK+N/DviZkB+voRvKLKqRARRMnKAIBxFQIIEYiavSu0rMeJI6h8FXNuOVQjs1qDAEGEQTa7CPsHFvt8O9u0K8bzcStFDbCcU/wkO792SZ4xMUkwiRIFJsgImGcYHeHF7oEvQTkYJ9EzW3k/SJeSVsNaW0zCfk9w+OTw7m1UYrGSPI/UpCf91utSW4ggY8uRgsS8MV40jUMyiaapAv0wpjnq3GgR1+MKAKW7szMW7/WmjKU/TEDqWCQphWh21yjLEJQ+sJFFxG4+7+kDNhF8HGmqgOhoqKaw+CKUEx0F4uPEZXtEZJ+BahC57QbcRBGOA/vRT6jE/joWLsHYVAZBXtoYM1lQEOwCLp4OV3GD2IERZp2NYjZW5qKEzbOkpLRPOjlpepWKtCtGD0et6xBliYi3JbIGb+8dQVTGBFmTHtnztqY9VjPiqUmnOFbSSZVqCPnJPINNVO+nr13 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR12MB6075.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(451199018)(316002)(38100700002)(41300700001)(8676002)(66556008)(66946007)(66476007)(6916009)(4326008)(5660300002)(7416002)(36756003)(86362001)(8936002)(921005)(2906002)(6506007)(1076003)(26005)(6512007)(186003)(478600001)(6486002)(83380400001)(107886003)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JfASZeIp8i0yUPk3uREhp1wDI4Nh6DZsGYlkivmJY2Dw8iqB0mOhvkMbB9zB?= =?us-ascii?Q?piFTVAU7MJURw7Z2cauU4JJCP7xvi/wgFLr94iivGgVghEQ3XhAYvWboQFpn?= =?us-ascii?Q?vR839n1sIB6usyy4DIW9nCjxKcYRoAPKRZ5X+jAhGOoCMbMZi87JKBhdyITe?= =?us-ascii?Q?TNOd210A75E7dXV2qvY74w4o00vXTgse7GBju3wZBD0G3UIb6wyNjJTJ9JxL?= =?us-ascii?Q?54LEObqmefVHjfDzoI51YNx18/yDwyerS0ssxwkSQsLjxwsO1QU4rO32sgNn?= =?us-ascii?Q?Mkag+Muyrcz3EG6Nz7uleOw5mgw5b3UmuiRY0m+rYTcZi5N2HrXsNMky6QP+?= =?us-ascii?Q?+6Jcl0kMz1AI98NX5KrqXvoP/79MFWsOqR4e7D+0l5kwGE1r2QYIR0WXGQ10?= =?us-ascii?Q?AyhWazaS6hJdz8vqNVR7RWRpy6vH/e4Tl3Yv3Dv0XbbJZd5b+oOTgUuFr93W?= =?us-ascii?Q?KfdFbxkKG94RlfvVqxyhk4NrTpmxiqsz/OZd8qTwih1rijcXxW5tH7Z75/Wj?= =?us-ascii?Q?ZovEvkjvLpewANytA56M87Jw51Wfu0+AO6SdAD8j1P5gahdpGab4hg0ZYUB6?= =?us-ascii?Q?ZoiDWibwd5J2y3FlbJlVUqycG26LK8ypmqqienaNmxXQ6VbbkjB1aBsRd7OO?= =?us-ascii?Q?7HqGjj7jCdYzjg6UJhxBZUebqCUe7c1EEvd8r4p8i1hBlK1d+asx/uO9t0+o?= =?us-ascii?Q?nt0AuilG9qsFoC44QXTHT/d6BzFST1PGV0lMaUmzpBEQ5j1fMXmx3G3LQppk?= =?us-ascii?Q?c4bV5PMmyD1FnMYhsYN+LxKHKGr8ucpEOZbUgJLGhZZsSlHtHiubQKhKYcDP?= =?us-ascii?Q?biAhDevdwcPskXD4WRnF3o0uDBn1IUKXwSy5cNM1cLYC5o8xeu2TzdcNQzrT?= =?us-ascii?Q?Nzrwzs2X6RUSztaQimiVX2Ng5PLKZiThnWz3DCCS3yNsYw/P0WdmFfz3l6Gx?= =?us-ascii?Q?fSvV6Cjy3t4g9VkclHDbaCJ3qQYG/2UCPcJNCMCj2K0wzK4crF3rVlPMQlHE?= =?us-ascii?Q?kHu6T7G6XfWRbuc0LROsa1LpF8Br+KkJmF7EjtZVtQJqmuv1Snk3BJkxy8Fi?= =?us-ascii?Q?doCb9ur4ey5Tqv0n5jgqwOuJdpyIJ2o0pnBglMtZ3hyk6r6kSe/viWX5nE/S?= =?us-ascii?Q?z6CPdcBe2IC+HGIxtNksjNq9DN2hzbo+10i0Z+QtNjgPmmby6nB0vBu8v5LL?= =?us-ascii?Q?Udt9qb6GqjcGrMCykek/P35UeoYL9uqoazBeKL8DAoKIWH3JC9uDMXA8ddb1?= =?us-ascii?Q?XJORB+i1BW6SHO1leN54N2Iur1NT+vDmSB3ieot6D1OxihjljKq0pCJAKnod?= =?us-ascii?Q?L84VFugvRV0fGMw0n2gnVxqZTNrFyZ0RnT+pDqcrqPDlxQWLEgxxIzIzrZRE?= =?us-ascii?Q?0k9fs8GSAFmeueymVNvX2Rwo7w4iv/mk1b38SX23sK+BNfVU2XtkF+aifFbx?= =?us-ascii?Q?FoNiluFXapFI8pDo5WUjHn01VQ+xMoiTSn/7udBEc+41Vxin9SFvaOSOj1Dz?= =?us-ascii?Q?EHXsYGpW3vREvk8q+vJxuPWi5Pz/BKGH2ljjnChG9J/vakRIZ9HmPgGTLRAv?= =?us-ascii?Q?MvYpBUj84y74XBQAskNa3d2g+ojMewVGfreYrS5z?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21b194b4-7726-45c0-61e2-08daffb97ebd X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6075.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 16:22:18.8126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7o4xmOfN6HQHVSrY9obivuYX72zNDGJ5cz9G9wPgsYjiz1zjEJqwHBS5LJknDF9D602BrXjBSWn6P8re0Do9lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5422 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_082222_034474_2F1D1C47 X-CRM114-Status: GOOD ( 10.26 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Ben Ben-Ishay When using direct data placement (DDP) the NIC could write the payload directly into the destination buffer and constructs SKBs such that they point to this data. To skip copies when SKB data already resides in the destination buffer we check if (src == dst), and skip the copy when it's true. Signed-off-by: Ben Ben-Ishay Signed-off-by: Boris Pismenny Signed-off-by: Or Gerlitz Signed-off-by: Yoray Zack Signed-off-by: Shai Malin Signed-off-by: Aurelien Aptel Reviewed-by: Chaitanya Kulkarni --- lib/iov_iter.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/iov_iter.c b/lib/iov_iter.c index f9a3ff37ecd1..2df634bb6d27 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -526,9 +526,15 @@ size_t _copy_to_iter(const void *addr, size_t bytes, struct iov_iter *i) return copy_pipe_to_iter(addr, bytes, i); if (user_backed_iter(i)) might_fault(); + /* + * When using direct data placement (DDP) the hardware writes + * data directly to the destination buffer, and constructs + * IOVs such that they point to this data. + * Thus, when the src == dst we skip the memcpy. + */ iterate_and_advance(i, bytes, base, len, off, copyout(base, addr + off, len), - memcpy(base, addr + off, len) + (base != addr + off) && memcpy(base, addr + off, len) ) return bytes; -- 2.31.1