From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C7B6C54EAA for ; Mon, 30 Jan 2023 17:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f8+EDJE3BPz4Fiz6Ke7G0WFXtMSgWykdC/S291mkm0c=; b=w5GDzsgYVzWcvnuluf37iuJ2nS zKqJdxBZdQ0JPyddE/Dn7MmBk8nZJpVsJ7Tnkx0+bO3dtfNEfH6SOz97189y2T7I5n/OUJQe4DP/l qSfDPWF5decmh1l3RQ6ht+LruG7uvcSmFkil/NwsJx+TePcp7x55aZFR6+hoi5doVfEnB1XG7FBvM D61tszB4JW+fhplTKZbdrqh0VLU4ioA3QT36DtNhoUcEKPDU/LdLqiE2qs+OEdZv/FVA8BSkcTTy9 S/h5MgVMLyMpf83VdagBU01OHqfC8HJr7rOaHedRPRqh2wFz/B30Bn/IK8Jq+w3LlLlGgxCqi7lsn nt8lau+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMYBF-004fMQ-OC; Mon, 30 Jan 2023 17:42:57 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMY9e-004ebK-20; Mon, 30 Jan 2023 17:41:19 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A6F2268D06; Mon, 30 Jan 2023 11:33:43 +0100 (CET) Date: Mon, 30 Jan 2023 11:33:43 +0100 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec Message-ID: <20230130103343.GA11663@lst.de> References: <20230130092157.1759539-21-hch@lst.de> <20230130092157.1759539-1-hch@lst.de> <3347459.1675074683@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3347459.1675074683@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_094118_293829_98EA181B X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 10:31:23AM +0000, David Howells wrote: > Christoph Hellwig wrote: > > > + bvec_set_page(&bv, ZERO_PAGE(0), len, 0); > > Maybe bvec_set_zero_page()? Why?