From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
Maciej Grochowski <Maciej.Grochowski@sony.com>
Subject: Re: [PATCH] nvme-pci: fix resume after AER recovery
Date: Tue, 31 Jan 2023 09:58:28 +0100 [thread overview]
Message-ID: <20230131085828.GB3139@lst.de> (raw)
In-Reply-To: <Y9gP0MvNpC/dgxQn@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Jan 30, 2023 at 11:43:28AM -0700, Keith Busch wrote:
> > Why isn't slot_reset being called after error_detected? Driver should be
> > returning "RESULT_NEEDS_RESET", which should have the pcie error handling
> > always invoke the slot_reset callback.
>
> Are you using an older kernel that doesn't have
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=387c72cdd7fb6bef650fb078d0f6ae9682abf631
Oh, that does looks like the real fix. That being said, what is
the point of flushing the reset_wor in nvme_error_resume?
next prev parent reply other threads:[~2023-01-31 8:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 10:14 [PATCH] nvme-pci: fix resume after AER recovery Christoph Hellwig
2023-01-30 18:35 ` Keith Busch
2023-01-30 18:43 ` Keith Busch
2023-01-30 18:54 ` Grochowski, Maciej
2023-01-31 8:58 ` Christoph Hellwig [this message]
2023-01-31 15:22 ` Keith Busch
2023-02-01 22:58 ` Grochowski, Maciej
2023-02-02 10:18 ` Christoph Hellwig
2023-02-02 18:47 ` Grochowski, Maciej
2023-02-02 19:43 ` Keith Busch
2023-02-03 1:29 ` Grochowski, Maciej
2023-02-03 1:37 ` Keith Busch
2023-02-03 18:45 ` Grochowski, Maciej
2023-02-06 14:02 ` Javier.gonz
2023-02-06 15:42 ` Christoph Hellwig
2023-02-06 16:22 ` Keith Busch
2023-02-06 17:51 ` Javier.gonz
2023-02-07 1:51 ` Grochowski, Maciej
2023-02-07 8:29 ` Javier.gonz
2023-02-07 10:36 ` Klaus Jensen
2023-02-07 19:05 ` Grochowski, Maciej
2023-02-08 6:43 ` Klaus Jensen
2023-02-08 17:26 ` Grochowski, Maciej
2023-02-08 17:39 ` Keith Busch
2023-02-08 22:38 ` Grochowski, Maciej
2023-02-09 7:55 ` Javier.gonz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131085828.GB3139@lst.de \
--to=hch@lst.de \
--cc=Maciej.Grochowski@sony.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox