From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 0/3] nvme: rework __nvme_submit_sync_cmd()
Date: Wed, 8 Feb 2023 09:49:36 +0100 [thread overview]
Message-ID: <20230208084939.145257-1-hare@suse.de> (raw)
Hi all,
as Jens and hch complained about the argument list to __nvme_submit_sync_cmd()
getting too long, here's now a patchset to clean things up.
The first patch is to split off __nvme_alloc_rq() from __nvme_submit_sync_cmd(),
which serves to reduce the number of arguments; it's also a nice cleanup as this
function can be utilized to replace some open-coded versions.
The second patch is to introduce a 'retry' argument to __nvme_alloc_rq(), to
indicate whether retries for this command should be allowd.
And the third is another cleanup; the 'at_head' argument to __nvme_submit_sync_cmd()
really should be a boolean, as it can take only two values, and it's being
converted into a boolean within __nvme_submit_sync_cmd() anyway.
As usual, comments and reviews are welcome.
Hannes Reinecke (3):
nvme: split __nvme_submit_sync_cmd()
nvme: retry internal commands if DNR status bit is not set
nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean
drivers/nvme/host/auth.c | 10 ++++--
drivers/nvme/host/core.c | 65 ++++++++++++++++++++++------------
drivers/nvme/host/fabrics.c | 46 +++++++++++++++++-------
drivers/nvme/host/ioctl.c | 2 +-
drivers/nvme/host/nvme.h | 11 +++---
drivers/nvme/host/pci.c | 9 +++--
drivers/nvme/target/passthru.c | 3 +-
7 files changed, 96 insertions(+), 50 deletions(-)
--
2.35.3
next reply other threads:[~2023-02-08 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 8:49 Hannes Reinecke [this message]
2023-02-08 8:49 ` [PATCH 1/3] nvme: split __nvme_submit_sync_cmd() Hannes Reinecke
2023-02-08 14:10 ` Kanchan Joshi
2023-02-08 15:03 ` Hannes Reinecke
2023-02-08 8:49 ` [PATCH 2/3] nvme: retry internal commands if DNR status bit is not set Hannes Reinecke
2023-02-08 14:02 ` Kanchan Joshi
2023-02-08 14:58 ` Hannes Reinecke
2023-02-08 8:49 ` [PATCH 3/3] nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208084939.145257-1-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox