From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/3] nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean
Date: Thu, 9 Feb 2023 06:20:18 +0100 [thread overview]
Message-ID: <20230209052018.GA8510@lst.de> (raw)
In-Reply-To: <20230208151720.109130-4-hare@suse.de>
On Wed, Feb 08, 2023 at 04:17:20PM +0100, Hannes Reinecke wrote:
> Use a boolean for the 'at_head' parameter in __nvme_submit_sync_cmd()
> to improve readability and consistency; it's being converted into a
> boolean anyway.
I'd much rather have an INSERT_AT_HEAD bit flag, going all the
way down to the block layer. The use of a boolean for this (and
also some other things in the block layer issue path) is really confusing.
next prev parent reply other threads:[~2023-02-09 5:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:17 [PATCHv2 0/3] nvme: rework __nvme_submit_sync_cmd() Hannes Reinecke
2023-02-08 15:17 ` [PATCH 1/3] nvme: split __nvme_submit_sync_cmd() Hannes Reinecke
2023-02-09 5:33 ` Christoph Hellwig
2023-02-09 7:58 ` Hannes Reinecke
2023-02-08 15:17 ` [PATCH 2/3] nvme: retry authentication commands if DNR status bit is not set Hannes Reinecke
2023-02-08 15:17 ` [PATCH 3/3] nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean Hannes Reinecke
2023-02-09 5:20 ` Christoph Hellwig [this message]
2023-02-09 10:59 ` Hannes Reinecke
2023-02-09 14:24 ` Kanchan Joshi
2023-02-08 15:30 ` [PATCHv2 0/3] nvme: rework __nvme_submit_sync_cmd() Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2023-02-08 8:49 [PATCH " Hannes Reinecke
2023-02-08 8:49 ` [PATCH 3/3] nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209052018.GA8510@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox