* [PATCH] nvme: fix sparse warning on effects masking
@ 2023-02-24 15:34 Keith Busch
2023-02-24 23:52 ` Chaitanya Kulkarni
2023-02-27 14:06 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2023-02-24 15:34 UTC (permalink / raw)
To: linux-nvme, hch; +Cc: sagi, Keith Busch, kernel test robot
From: Keith Busch <kbusch@kernel.org>
The log entries are stored in le32, so use appropriate byte swapping
macros.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202302242222.PevBhzvC-lkp@intel.com/
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 8698410aeb843..d2f88b71f92ae 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3104,7 +3104,7 @@ static void nvme_init_known_nvm_effects(struct nvme_ctrl *ctrl)
* Rather than blindly freezing the IO queues for this effect that
* doesn't even apply to IO, mask it off.
*/
- log->acs[nvme_admin_security_recv] &= ~NVME_CMD_EFFECTS_CSE_MASK;
+ log->acs[nvme_admin_security_recv] &= cpu_to_le32(~NVME_CMD_EFFECTS_CSE_MASK);
log->iocs[nvme_cmd_write] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC);
log->iocs[nvme_cmd_write_zeroes] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: fix sparse warning on effects masking
2023-02-24 15:34 [PATCH] nvme: fix sparse warning on effects masking Keith Busch
@ 2023-02-24 23:52 ` Chaitanya Kulkarni
2023-02-27 14:06 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2023-02-24 23:52 UTC (permalink / raw)
To: Keith Busch, linux-nvme@lists.infradead.org, hch@lst.de
Cc: sagi@grimberg.me, Keith Busch, kernel test robot
On 2/24/2023 7:34 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The log entries are stored in le32, so use appropriate byte swapping
> macros.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302242222.PevBhzvC-lkp@intel.com/
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: fix sparse warning on effects masking
2023-02-24 15:34 [PATCH] nvme: fix sparse warning on effects masking Keith Busch
2023-02-24 23:52 ` Chaitanya Kulkarni
@ 2023-02-27 14:06 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-02-27 14:06 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi, Keith Busch, kernel test robot
Thanks,
applied to nvme-6.3.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-27 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-24 15:34 [PATCH] nvme: fix sparse warning on effects masking Keith Busch
2023-02-24 23:52 ` Chaitanya Kulkarni
2023-02-27 14:06 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox