From: Chaitanya Kulkarni <kch@nvidia.com>
To: <linux-nvme@lists.infradead.org>
Cc: <kbusch@kernel.org>, <hch@lst.de>, <sagi@grimberg.me>,
<hare@suse.de>, Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH 2/9] nvme-core: remove unnecessary else
Date: Wed, 22 Mar 2023 20:36:29 -0700 [thread overview]
Message-ID: <20230323033636.812758-3-kch@nvidia.com> (raw)
In-Reply-To: <20230323033636.812758-1-kch@nvidia.com>
By returning early we can safely remove the unnecessary else part
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/host/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c9636be68d74..ce516553b517 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4475,9 +4475,10 @@ static void nvme_scan_ns(struct nvme_ctrl *ctrl, unsigned nsid)
if (ns) {
nvme_validate_ns(ns, &info);
nvme_put_ns(ns);
- } else {
- nvme_alloc_ns(ctrl, &info);
+ return;
}
+
+ nvme_alloc_ns(ctrl, &info);
}
static void nvme_remove_invalid_namespaces(struct nvme_ctrl *ctrl,
--
2.29.0
next prev parent reply other threads:[~2023-03-23 3:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 3:36 [PATCH 0/9] nvme-core: trivial cleanups Chaitanya Kulkarni
2023-03-23 3:36 ` [PATCH 1/9] nvme-core: use uint type for shutdown timeout Chaitanya Kulkarni
2023-03-23 7:56 ` Sagi Grimberg
2023-03-23 22:21 ` Chaitanya Kulkarni
2023-03-23 22:37 ` Chaitanya Kulkarni
2023-03-26 7:22 ` Sagi Grimberg
2023-03-26 23:06 ` Chaitanya Kulkarni
2023-03-23 3:36 ` Chaitanya Kulkarni [this message]
2023-03-23 7:57 ` [PATCH 2/9] nvme-core: remove unnecessary else Sagi Grimberg
2023-03-23 3:36 ` [PATCH 3/9] nvme-core: remvoe extra line at end of function Chaitanya Kulkarni
2023-03-23 7:57 ` Sagi Grimberg
2023-03-23 3:36 ` [PATCH 4/9] nvme-core: code cleanup for __nvme_check_ready() Chaitanya Kulkarni
2023-03-23 8:02 ` Sagi Grimberg
2023-03-23 22:24 ` Chaitanya Kulkarni
2023-03-23 3:36 ` [PATCH 5/9] nvme-core: use normal pattern Chaitanya Kulkarni
2023-03-23 8:04 ` Sagi Grimberg
2023-03-23 17:50 ` Keith Busch
2023-03-23 22:01 ` Chaitanya Kulkarni
2023-03-23 3:36 ` [PATCH 6/9] nvme-core: open code nvme_delete_ctrl_sync() Chaitanya Kulkarni
2023-03-23 8:05 ` Sagi Grimberg
2023-03-23 3:36 ` [PATCH 7/9] nvme-core: cleanup for nvme_set_latency_tolerance Chaitanya Kulkarni
2023-03-23 8:06 ` Sagi Grimberg
2023-03-23 3:36 ` [PATCH 8/9] nvme-core: remove unneacessary else Chaitanya Kulkarni
2023-03-23 8:06 ` Sagi Grimberg
2023-03-23 3:36 ` [PATCH 9/9] nvme-core: fix nvme_submit_sync_cmd() args Chaitanya Kulkarni
2023-03-23 8:16 ` Sagi Grimberg
2023-03-23 8:23 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323033636.812758-3-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox