public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH blktests v2 0/3] Test different queue counts
Date: Thu, 23 Mar 2023 11:06:53 +0000	[thread overview]
Message-ID: <20230323110651.fdblmaj4fac2x5qh@shindev> (raw)
In-Reply-To: <20230322101648.31514-1-dwagner@suse.de>

On Mar 22, 2023 / 11:16, Daniel Wagner wrote:
> Setup different queues, e.g. read and poll queues.
> 
> There is still the problem that _require_nvme_trtype_is_fabrics also includes
> the loop transport which has no support for different queue types.
> 
> See also https://lore.kernel.org/linux-nvme/20230322002350.4038048-1-kbusch@meta.com/

Hi Daniel, thanks for the patches. The new test case catches some bugs. Looks
valuable.

I ran the test case using various nvme_trtype on kernel v6.2 and v6.3-rc3, and
observed hangs. I applied the 3rd patch in the link above on top of v6.3-rc3 and
confirmed the hang disappears. I would like to wait for the kernel fix patch
delivered to upstream, before adding this test case to blktests master.

When I ran the test case without setting nvme_trtype, kernel reported messages
below:

[  199.621431][ T1001] nvme_fabrics: invalid parameter 'nr_write_queues=%d'
[  201.271200][ T1030] nvme_fabrics: invalid parameter 'nr_write_queues=%d'
[  201.272155][ T1030] nvme_fabrics: invalid parameter 'nr_poll_queues=%d'

Is it useful to run the test case with default nvme_trtype=loop?

-- 
Shin'ichiro Kawasaki

  parent reply	other threads:[~2023-03-23 11:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 10:16 [PATCH blktests v2 0/3] Test different queue counts Daniel Wagner
2023-03-22 10:16 ` [PATCH blktests v2 1/3] nvme/rc: Parse optional arguments in _nvme_connect_subsys() Daniel Wagner
2023-03-22 11:08   ` Daniel Wagner
2023-03-23 10:45   ` Shinichiro Kawasaki
2023-03-22 10:16 ` [PATCH blktests v2 2/3] nvme/rc: Add nr queue parser arguments Daniel Wagner
2023-03-23 10:46   ` Shinichiro Kawasaki
2023-03-22 10:16 ` [PATCH blktests v2 3/3] nvme/047: Test different queue counts Daniel Wagner
2023-03-23 10:55   ` Shinichiro Kawasaki
2023-03-23 11:06 ` Shinichiro Kawasaki [this message]
2023-03-27 15:41   ` [PATCH blktests v2 0/3] " Daniel Wagner
2023-03-28  8:45     ` Shinichiro Kawasaki
2023-03-28 18:20       ` Chaitanya Kulkarni
2023-03-29  0:57         ` Shinichiro Kawasaki
2023-03-28 18:35 ` Keith Busch
2023-03-29  3:30   ` Chaitanya Kulkarni
2023-03-29  6:25     ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323110651.fdblmaj4fac2x5qh@shindev \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=chaitanyak@nvidia.com \
    --cc=dwagner@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox