Re: [RFC v2 3/3] nvme: ignore starting sector while error logging for passthrough requests

alan.adamson
2023-03-28T20:39:49Z

On 3/28/23 1:56 AM, Sagi Grimberg wrote:
>
>> Yikes, no.  Anything that needs to poke into details of passthrough
>> commands is fundamentally wrong.  Maybe we need a separate log
>> message for passthrough that is just based on the cdw values instead
>> of trying to decode it.
>
> Agree

We can do something like this:

nvme0: Unknown(0x96), Invalid Command Opcode (sct 0x0 / sc 0x1) DNR :
cdw10=0x1 cdw11=0x0 cdw12=0x0 cdw13=0x0 cdw14=0x0 cdw15=0x0

nvme0n1: Read(0x2), LBA Out of Range (sct 0x0 / sc 0x80) DNR : cdw10=0x0
cdw11=0x1 cdw12=0x70000 cdw13=0x0 cdw14=0x0 cdw15=0x0

Alan