From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60442C74A5B for ; Wed, 29 Mar 2023 13:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LqW3RkMFvF3gcVAk619NmosOWZV1qP/XTRHnRjCzqSk=; b=W0VLpJO7ELqVCLkmiX3XJV/QOy pPXDQfTC5dClZWPf8iwawRg7ot4oWcP5eafG6fsiojRYBbFq+xFBY/dtF2yhTw4CTCeRlQD9UzT6a T2t2awO5ZxXuneRNSSs3zw0is/cJccr2fiOKaHW8+3Srv/D5zvOHeE/DuYUSu1fTazELTdYgGWRx4 U/IsViUftiBHoCSZQ2noLcd3panf87YKQ0dGaxeLcrp7MrLNqjXfLuFV58fkAzQAYadImX+ZDLyHp KwqRHkRROKjHTo+fkYEmNMmIIHKNZAS9VEz/3Ocnn43KedUciqLHh/lJc11wS8pFVRRI1BHsQoEAh GGrRYPLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phWJl-000UTj-0d; Wed, 29 Mar 2023 13:58:25 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phWJh-000URv-1i for linux-nvme@lists.infradead.org; Wed, 29 Mar 2023 13:58:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680098301; x=1711634301; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ck3URVmLgHrVhcVJ5gg7rR62G4o0wwV83BuwrsZ3cYk=; b=RQ5ku+hWPbkvGQFbRiD7Z4xWCow0KRKdj9sEOrlND7GcCzW1ev7jlFn/ RwmADWaDRQfsnVZqFNLUUCSFfPJgpl/mkBnFTtQtRrKWXXLOo7wqYX5Wu rjw/XA+KWR6UPn0b4oARZVPYmTWtc0tvrs2cpWzodRvQ7l8dp63NmR4+V yN0XjzmeYkw4vZ7MooBprUGsy74EtQP4XqUxzwdFQkXZl5oUg9LFnRHdU +HD3HX+Lbe5PkWWJU8oJXghS7xdEyTgelCNqZAuTCDA+EaSuv8t7e4L+N NptiCNpwylg7P1u+xg840TbzLoM/C7Tt6U7/tgdsdjG5a5aMZNvKvw+8D A==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="329348384" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="329348384" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 06:58:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="716892985" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="716892985" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 29 Mar 2023 06:57:54 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1phWJF-000Jb6-0H; Wed, 29 Mar 2023 13:57:53 +0000 Date: Wed, 29 Mar 2023 21:56:55 +0800 From: kernel test robot To: Anuj Gupta , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , James Smart , Chaitanya Kulkarni , Alexander Viro , Christian Brauner Cc: oe-kbuild-all@lists.linux.dev, bvanassche@acm.org, hare@suse.de, ming.lei@redhat.com, damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, Nitesh Shetty , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns Message-ID: <202303292148.Pbx4mDpS-lkp@intel.com> References: <20230327084103.21601-7-anuj20.g@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327084103.21601-7-anuj20.g@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230329_065821_615230_E2D8E577 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Anuj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linus/master v6.3-rc4 next-20230329] [cannot apply to device-mapper-dm/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20230327084103.21601-7-anuj20.g%40samsung.com patch subject: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns config: arm64-randconfig-s041-20230329 (https://download.01.org/0day-ci/archive/20230329/202303292148.Pbx4mDpS-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/f846a8ac40882d9d42532e9e2b43560650ef8510 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 git checkout f846a8ac40882d9d42532e9e2b43560650ef8510 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/nvme/target/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303292148.Pbx4mDpS-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: got restricted __le16 [usertype] mssrl >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:57:29: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: got restricted __le16 [usertype] mssrl drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 vim +55 drivers/nvme/target/io-cmd-bdev.c 12 13 void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id) 14 { 15 /* Logical blocks per physical block, 0's based. */ 16 const __le16 lpp0b = to0based(bdev_physical_block_size(bdev) / 17 bdev_logical_block_size(bdev)); 18 19 /* 20 * For NVMe 1.2 and later, bit 1 indicates that the fields NAWUN, 21 * NAWUPF, and NACWU are defined for this namespace and should be 22 * used by the host for this namespace instead of the AWUN, AWUPF, 23 * and ACWU fields in the Identify Controller data structure. If 24 * any of these fields are zero that means that the corresponding 25 * field from the identify controller data structure should be used. 26 */ 27 id->nsfeat |= 1 << 1; 28 id->nawun = lpp0b; 29 id->nawupf = lpp0b; 30 id->nacwu = lpp0b; 31 32 /* 33 * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and 34 * NOWS are defined for this namespace and should be used by 35 * the host for I/O optimization. 36 */ 37 id->nsfeat |= 1 << 4; 38 /* NPWG = Namespace Preferred Write Granularity. 0's based */ 39 id->npwg = lpp0b; 40 /* NPWA = Namespace Preferred Write Alignment. 0's based */ 41 id->npwa = id->npwg; 42 /* NPDG = Namespace Preferred Deallocate Granularity. 0's based */ 43 id->npdg = to0based(bdev_discard_granularity(bdev) / 44 bdev_logical_block_size(bdev)); 45 /* NPDG = Namespace Preferred Deallocate Alignment */ 46 id->npda = id->npdg; 47 /* NOWS = Namespace Optimal Write Size */ 48 id->nows = to0based(bdev_io_opt(bdev) / bdev_logical_block_size(bdev)); 49 50 /*Copy limits*/ 51 if (bdev_max_copy_sectors(bdev)) { 52 id->msrc = id->msrc; 53 id->mssrl = cpu_to_le16((bdev_max_copy_sectors(bdev) << 54 SECTOR_SHIFT) / bdev_logical_block_size(bdev)); > 55 id->mcl = cpu_to_le32(id->mssrl); 56 } else { 57 id->msrc = (u8)to0based(BIO_MAX_VECS - 1); 58 id->mssrl = cpu_to_le16((BIO_MAX_VECS << PAGE_SHIFT) / 59 bdev_logical_block_size(bdev)); 60 id->mcl = cpu_to_le32(id->mssrl); 61 } 62 } 63 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests