From: Uday Shankar <ushankar@purestorage.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Costa Sapuntzakis <costa@purestorage.com>,
Randy Jennings <randyj@purestorage.com>,
Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/3] nvme: check IO start time when deciding to defer KA
Date: Thu, 20 Apr 2023 13:37:45 -0600 [thread overview]
Message-ID: <20230420193745.GA84552@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <c7e4a236-8776-d611-ed9a-ed46b14081fb@grimberg.me>
On Tue, Apr 18, 2023 at 07:56:58PM +0300, Sagi Grimberg wrote:
> > + if (ctrl->kas && !ctrl->comp_seen
> > + && nvme_req(req)->start_time >= ctrl->ka_last_check_time)
> > ctrl->comp_seen = true;
>
> indentation is wrong here.
>
> > @@ -1028,6 +1027,8 @@ static inline void nvme_start_request(struct request *rq)
> > {
> > if (rq->cmd_flags & REQ_NVME_MPATH)
> > nvme_mpath_start_request(rq);
> > + else
> > + nvme_req(rq)->start_time = jiffies;
>
> nvme_mpath_start_request may not set the start_time if stats are
> disabled...
Thanks for catching these, I'll fix them up in a v2.
next prev parent reply other threads:[~2023-04-20 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 22:55 [PATCH 0/3] keepalive bugfixes Uday Shankar
2023-04-17 22:55 ` [PATCH 1/3] nvme: double KA polling frequency to avoid KATO with TBKAS on Uday Shankar
2023-04-18 16:03 ` Sagi Grimberg
2023-04-18 16:48 ` Hannes Reinecke
2023-04-17 22:55 ` [PATCH 2/3] nvme: check IO start time when deciding to defer KA Uday Shankar
2023-04-18 16:56 ` Sagi Grimberg
2023-04-20 19:37 ` Uday Shankar [this message]
2023-04-17 22:55 ` [PATCH 3/3] nvme: improve handling of long keep alives Uday Shankar
2023-04-18 16:59 ` Sagi Grimberg
2023-04-20 19:34 ` Uday Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420193745.GA84552@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=axboe@fb.com \
--cc=costa@purestorage.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox