From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v3 12/12] nvme: Make the number iterations configurable
Date: Wed, 3 May 2023 10:02:58 +0200 [thread overview]
Message-ID: <20230503080258.14525-13-dwagner@suse.de> (raw)
In-Reply-To: <20230503080258.14525-1-dwagner@suse.de>
Some tests hard code high values of iterations. This makes them run
relatively long compared to the other tests. Introduce a new environment
variable nvme_num_iter to allow tune the runtime.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
Documentation/running-tests.md | 2 ++
tests/nvme/016 | 2 +-
tests/nvme/017 | 2 +-
tests/nvme/rc | 1 +
4 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/running-tests.md b/Documentation/running-tests.md
index 6b34a253fd97..243975e43583 100644
--- a/Documentation/running-tests.md
+++ b/Documentation/running-tests.md
@@ -107,6 +107,8 @@ The NVMe tests can be additionally parameterized via environment variables.
- nvme_img_size: '1G' (default)
Run the tests with given image size in bytes. 'm' and 'g' postfix
are supported.
+- nvme_num_iter: 1000 (default)
+ The number of iterations a test should do.
### Running nvme-rdma nvmeof-mp srp tests
diff --git a/tests/nvme/016 b/tests/nvme/016
index 4eba30223a08..c0c31a55b190 100755
--- a/tests/nvme/016
+++ b/tests/nvme/016
@@ -17,7 +17,7 @@ test() {
echo "Running ${TEST_NAME}"
local port
- local iterations=1000
+ local iterations="${nvme_num_iter}"
local loop_dev
local subsys_nqn="blktests-subsystem-1"
diff --git a/tests/nvme/017 b/tests/nvme/017
index 0248aee9bc41..e1674508f654 100755
--- a/tests/nvme/017
+++ b/tests/nvme/017
@@ -18,7 +18,7 @@ test() {
local port
local file_path
- local iterations=1000
+ local iterations="${nvme_num_iter}"
local subsys_name="blktests-subsystem-1"
_setup_nvmet
diff --git a/tests/nvme/rc b/tests/nvme/rc
index a14458d5b80f..76ca683a40b4 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -18,6 +18,7 @@ def_hostnqn="$(cat /etc/nvme/hostnqn 2> /dev/null)"
def_hostid="$(cat /etc/nvme/hostid 2> /dev/null)"
nvme_trtype=${nvme_trtype:-"loop"}
nvme_img_size=${nvme_img_size:-"1G"}
+nvme_num_iter=${nvme_num_iter:-"1000"}
_nvme_requires() {
_have_program nvme
--
2.40.0
next prev parent reply other threads:[~2023-05-03 8:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 8:02 [PATCH blktests v3 00/12] nvme testsuite runtime optimization Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 01/12] nvme/rc: Auto convert test device size info Daniel Wagner
2023-05-03 9:22 ` Chaitanya Kulkarni
2023-05-03 9:26 ` Daniel Wagner
2023-05-07 22:49 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 02/12] nvme: Do not hard code device size for dd test Daniel Wagner
2023-05-03 9:23 ` Chaitanya Kulkarni
2023-05-07 22:51 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 03/12] common/xfs: Make size argument optional for _xfs_run_fio_verify_io Daniel Wagner
2023-05-03 9:25 ` Chaitanya Kulkarni
2023-05-03 8:02 ` [PATCH blktests v3 04/12] common/xfs: Limit fio size job to fit into xfs fs Daniel Wagner
2023-05-03 9:29 ` Chaitanya Kulkarni
2023-05-03 9:42 ` Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs Daniel Wagner
2023-05-07 22:56 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 06/12] Documentation: Add info on nvme_tr_type Daniel Wagner
2023-05-03 9:32 ` Chaitanya Kulkarni
2023-05-07 23:21 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 07/12] nvme: Make test image size configurable Daniel Wagner
2023-05-03 9:32 ` Chaitanya Kulkarni
2023-05-07 23:09 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 08/12] nvme/rc: Add minimal test image size requirement Daniel Wagner
2023-05-03 9:35 ` Chaitanya Kulkarni
2023-05-07 23:19 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 09/12] common/fio: Limit number of random jobs Daniel Wagner
2023-05-03 9:41 ` Chaitanya Kulkarni
2023-05-03 11:01 ` Daniel Wagner
2023-05-04 5:16 ` Chaitanya Kulkarni
2023-05-04 6:07 ` Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random fio jobs Daniel Wagner
2023-05-07 23:31 ` Shinichiro Kawasaki
2023-05-10 17:14 ` Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 11/12] nvme/rc: Move discovery generation counter code to rc Daniel Wagner
2023-05-07 23:34 ` Shinichiro Kawasaki
2023-05-10 17:24 ` Daniel Wagner
2023-05-11 16:44 ` Shinichiro Kawasaki
2023-05-03 8:02 ` Daniel Wagner [this message]
2023-05-03 9:45 ` [PATCH blktests v3 12/12] nvme: Make the number iterations configurable Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503080258.14525-13-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox