public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
	Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v3 02/12] nvme: Do not hard code device size for dd test
Date: Wed,  3 May 2023 10:02:48 +0200	[thread overview]
Message-ID: <20230503080258.14525-3-dwagner@suse.de> (raw)
In-Reply-To: <20230503080258.14525-1-dwagner@suse.de>

Read the block device sizes instead hard coding them,
so that the device size can be configurable in future.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/014 | 10 +++++++++-
 tests/nvme/015 | 10 +++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/tests/nvme/014 b/tests/nvme/014
index d13cff7921da..875e99eea346 100755
--- a/tests/nvme/014
+++ b/tests/nvme/014
@@ -23,6 +23,9 @@ test() {
 	local port
 	local nvmedev
 	local loop_dev
+	local size
+	local bs
+	local count
 	local file_path="$TMPDIR/img"
 	local subsys_name="blktests-subsystem-1"
 
@@ -41,7 +44,12 @@ test() {
 	cat "/sys/block/${nvmedev}n1/uuid"
 	cat "/sys/block/${nvmedev}n1/wwid"
 
-	dd if=/dev/urandom of="/dev/${nvmedev}n1" count=128000 bs=4k status=none
+	size="$(blockdev --getsize64 "/dev/${nvmedev}n1")"
+	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
+	count=$((size / bs))
+
+	dd if=/dev/urandom of="/dev/${nvmedev}n1" \
+		count="${count}" bs="${bs}" status=none
 
 	nvme flush "/dev/${nvmedev}" -n 1
 
diff --git a/tests/nvme/015 b/tests/nvme/015
index bb52ba2598db..8cb343e1d31c 100755
--- a/tests/nvme/015
+++ b/tests/nvme/015
@@ -22,6 +22,9 @@ test() {
 
 	local port
 	local nvmedev
+	local size
+	local bs
+	local count
 	local file_path="$TMPDIR/img"
 	local subsys_name="blktests-subsystem-1"
 
@@ -38,7 +41,12 @@ test() {
 	cat "/sys/block/${nvmedev}n1/uuid"
 	cat "/sys/block/${nvmedev}n1/wwid"
 
-	dd if=/dev/urandom of="/dev/${nvmedev}n1" count=128000 bs=4k status=none
+	size="$(blockdev --getsize64 "/dev/${nvmedev}n1")"
+	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
+	count=$((size / bs))
+
+	dd if=/dev/urandom of="/dev/${nvmedev}n1" \
+		count="${count}" bs="${bs}" status=none
 
 	nvme flush "/dev/${nvmedev}n1" -n 1
 
-- 
2.40.0



  parent reply	other threads:[~2023-05-03  8:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  8:02 [PATCH blktests v3 00/12] nvme testsuite runtime optimization Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 01/12] nvme/rc: Auto convert test device size info Daniel Wagner
2023-05-03  9:22   ` Chaitanya Kulkarni
2023-05-03  9:26     ` Daniel Wagner
2023-05-07 22:49   ` Shinichiro Kawasaki
2023-05-03  8:02 ` Daniel Wagner [this message]
2023-05-03  9:23   ` [PATCH blktests v3 02/12] nvme: Do not hard code device size for dd test Chaitanya Kulkarni
2023-05-07 22:51   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 03/12] common/xfs: Make size argument optional for _xfs_run_fio_verify_io Daniel Wagner
2023-05-03  9:25   ` Chaitanya Kulkarni
2023-05-03  8:02 ` [PATCH blktests v3 04/12] common/xfs: Limit fio size job to fit into xfs fs Daniel Wagner
2023-05-03  9:29   ` Chaitanya Kulkarni
2023-05-03  9:42     ` Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs Daniel Wagner
2023-05-07 22:56   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 06/12] Documentation: Add info on nvme_tr_type Daniel Wagner
2023-05-03  9:32   ` Chaitanya Kulkarni
2023-05-07 23:21   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 07/12] nvme: Make test image size configurable Daniel Wagner
2023-05-03  9:32   ` Chaitanya Kulkarni
2023-05-07 23:09   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 08/12] nvme/rc: Add minimal test image size requirement Daniel Wagner
2023-05-03  9:35   ` Chaitanya Kulkarni
2023-05-07 23:19   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 09/12] common/fio: Limit number of random jobs Daniel Wagner
2023-05-03  9:41   ` Chaitanya Kulkarni
2023-05-03 11:01     ` Daniel Wagner
2023-05-04  5:16       ` Chaitanya Kulkarni
2023-05-04  6:07         ` Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random fio jobs Daniel Wagner
2023-05-07 23:31   ` Shinichiro Kawasaki
2023-05-10 17:14     ` Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 11/12] nvme/rc: Move discovery generation counter code to rc Daniel Wagner
2023-05-07 23:34   ` Shinichiro Kawasaki
2023-05-10 17:24     ` Daniel Wagner
2023-05-11 16:44       ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 12/12] nvme: Make the number iterations configurable Daniel Wagner
2023-05-03  9:45   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503080258.14525-3-dwagner@suse.de \
    --to=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=shinichiro@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox