public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
	Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v3 03/12] common/xfs: Make size argument optional for _xfs_run_fio_verify_io
Date: Wed,  3 May 2023 10:02:49 +0200	[thread overview]
Message-ID: <20230503080258.14525-4-dwagner@suse.de> (raw)
In-Reply-To: <20230503080258.14525-1-dwagner@suse.de>

Make the size argument optional by reading the filesystem info. The
caller doesn't have to guess (or calculate) how big the max IO size.
The log data structure of XFS is reducing the capacity.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 common/xfs     | 14 +++++++++++++-
 tests/nvme/012 |  2 +-
 tests/nvme/013 |  2 +-
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/common/xfs b/common/xfs
index 2c5d96164ac1..413c2820ffaf 100644
--- a/common/xfs
+++ b/common/xfs
@@ -24,10 +24,22 @@ _xfs_run_fio_verify_io() {
 	local mount_dir="/mnt/blktests"
 	local bdev=$1
 	local sz=$2
+	local sz_mb
+	local avail
+	local avail_mb
 
 	_xfs_mkfs_and_mount "${bdev}" "${mount_dir}" >> "${FULL}" 2>&1
 
-	_run_fio_verify_io --size="$sz" --directory="${mount_dir}/"
+	avail="$(df --output=avail "${mount_dir}" | tail -1)"
+	avail_mb="$((avail / 1024))"
+
+	if [[ -z "${sz}" ]]; then
+		sz_mb="${avail_mb}"
+	else
+		sz_mb="$(convert_to_mb "${sz}")"
+	fi
+
+	_run_fio_verify_io --size="${sz_mb}m" --directory="${mount_dir}/"
 
 	umount "${mount_dir}" >> "${FULL}" 2>&1
 	rm -fr "${mount_dir}"
diff --git a/tests/nvme/012 b/tests/nvme/012
index e60082c2e751..c9d24388306d 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -44,7 +44,7 @@ test() {
 	cat "/sys/block/${nvmedev}n1/uuid"
 	cat "/sys/block/${nvmedev}n1/wwid"
 
-	_xfs_run_fio_verify_io "/dev/${nvmedev}n1" "900m"
+	_xfs_run_fio_verify_io "/dev/${nvmedev}n1"
 
 	_nvme_disconnect_subsys "${subsys_name}"
 
diff --git a/tests/nvme/013 b/tests/nvme/013
index 9d60a7df4577..265b6968fd34 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -41,7 +41,7 @@ test() {
 	cat "/sys/block/${nvmedev}n1/uuid"
 	cat "/sys/block/${nvmedev}n1/wwid"
 
-	_xfs_run_fio_verify_io "/dev/${nvmedev}n1" "900m"
+	_xfs_run_fio_verify_io "/dev/${nvmedev}n1"
 
 	_nvme_disconnect_subsys "${subsys_name}"
 
-- 
2.40.0



  parent reply	other threads:[~2023-05-03  8:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  8:02 [PATCH blktests v3 00/12] nvme testsuite runtime optimization Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 01/12] nvme/rc: Auto convert test device size info Daniel Wagner
2023-05-03  9:22   ` Chaitanya Kulkarni
2023-05-03  9:26     ` Daniel Wagner
2023-05-07 22:49   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 02/12] nvme: Do not hard code device size for dd test Daniel Wagner
2023-05-03  9:23   ` Chaitanya Kulkarni
2023-05-07 22:51   ` Shinichiro Kawasaki
2023-05-03  8:02 ` Daniel Wagner [this message]
2023-05-03  9:25   ` [PATCH blktests v3 03/12] common/xfs: Make size argument optional for _xfs_run_fio_verify_io Chaitanya Kulkarni
2023-05-03  8:02 ` [PATCH blktests v3 04/12] common/xfs: Limit fio size job to fit into xfs fs Daniel Wagner
2023-05-03  9:29   ` Chaitanya Kulkarni
2023-05-03  9:42     ` Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs Daniel Wagner
2023-05-07 22:56   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 06/12] Documentation: Add info on nvme_tr_type Daniel Wagner
2023-05-03  9:32   ` Chaitanya Kulkarni
2023-05-07 23:21   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 07/12] nvme: Make test image size configurable Daniel Wagner
2023-05-03  9:32   ` Chaitanya Kulkarni
2023-05-07 23:09   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 08/12] nvme/rc: Add minimal test image size requirement Daniel Wagner
2023-05-03  9:35   ` Chaitanya Kulkarni
2023-05-07 23:19   ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 09/12] common/fio: Limit number of random jobs Daniel Wagner
2023-05-03  9:41   ` Chaitanya Kulkarni
2023-05-03 11:01     ` Daniel Wagner
2023-05-04  5:16       ` Chaitanya Kulkarni
2023-05-04  6:07         ` Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random fio jobs Daniel Wagner
2023-05-07 23:31   ` Shinichiro Kawasaki
2023-05-10 17:14     ` Daniel Wagner
2023-05-03  8:02 ` [PATCH blktests v3 11/12] nvme/rc: Move discovery generation counter code to rc Daniel Wagner
2023-05-07 23:34   ` Shinichiro Kawasaki
2023-05-10 17:24     ` Daniel Wagner
2023-05-11 16:44       ` Shinichiro Kawasaki
2023-05-03  8:02 ` [PATCH blktests v3 12/12] nvme: Make the number iterations configurable Daniel Wagner
2023-05-03  9:45   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503080258.14525-4-dwagner@suse.de \
    --to=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=shinichiro@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox