From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs
Date: Wed, 3 May 2023 10:02:51 +0200 [thread overview]
Message-ID: <20230503080258.14525-6-dwagner@suse.de> (raw)
In-Reply-To: <20230503080258.14525-1-dwagner@suse.de>
The fio jobs are supposed to run long in background during the test.
Instead relying on a job size use explicit runtime for this.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/032 | 4 ++--
tests/nvme/040 | 9 +++++++--
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/nvme/032 b/tests/nvme/032
index 017d4a339971..2e4b7f0760c7 100755
--- a/tests/nvme/032
+++ b/tests/nvme/032
@@ -38,8 +38,8 @@ test_device() {
sysfs="/sys/bus/pci/devices/${pdev}"
# start fio job
- _run_fio_rand_io --filename="$TEST_DEV" --size=1g \
- --group_reporting &> /dev/null &
+ _run_fio_rand_io --filename="$TEST_DEV" \
+ --group_reporting --time_based --runtime=-1 &> /dev/null &
sleep 5
diff --git a/tests/nvme/040 b/tests/nvme/040
index 04bd726cd309..05b4f5472ef5 100755
--- a/tests/nvme/040
+++ b/tests/nvme/040
@@ -21,6 +21,7 @@ test() {
local port
local loop_dev
local nvmedev
+ local fio_pid
echo "Running ${TEST_NAME}"
@@ -37,8 +38,10 @@ test() {
# start fio job
echo "starting background fio"
- _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size=1g \
- --group_reporting --ramp_time=5 &> /dev/null &
+ _run_fio_rand_io --filename="/dev/${nvmedev}n1" \
+ --group_reporting --ramp_time=5 \
+ --time_based --runtime=-1 &> /dev/null &
+ fio_pid=$!
sleep 5
# do reset/remove operation
@@ -48,6 +51,8 @@ test() {
echo "deleting controller"
_nvme_delete_ctrl "${nvmedev}"
+ { kill "${fio_pid}"; wait; } &> /dev/null
+
_remove_nvmet_subsystem_from_port "${port}" "${subsys}"
_remove_nvmet_subsystem "${subsys}"
_remove_nvmet_port "${port}"
--
2.40.0
next prev parent reply other threads:[~2023-05-03 8:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 8:02 [PATCH blktests v3 00/12] nvme testsuite runtime optimization Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 01/12] nvme/rc: Auto convert test device size info Daniel Wagner
2023-05-03 9:22 ` Chaitanya Kulkarni
2023-05-03 9:26 ` Daniel Wagner
2023-05-07 22:49 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 02/12] nvme: Do not hard code device size for dd test Daniel Wagner
2023-05-03 9:23 ` Chaitanya Kulkarni
2023-05-07 22:51 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 03/12] common/xfs: Make size argument optional for _xfs_run_fio_verify_io Daniel Wagner
2023-05-03 9:25 ` Chaitanya Kulkarni
2023-05-03 8:02 ` [PATCH blktests v3 04/12] common/xfs: Limit fio size job to fit into xfs fs Daniel Wagner
2023-05-03 9:29 ` Chaitanya Kulkarni
2023-05-03 9:42 ` Daniel Wagner
2023-05-03 8:02 ` Daniel Wagner [this message]
2023-05-07 22:56 ` [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 06/12] Documentation: Add info on nvme_tr_type Daniel Wagner
2023-05-03 9:32 ` Chaitanya Kulkarni
2023-05-07 23:21 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 07/12] nvme: Make test image size configurable Daniel Wagner
2023-05-03 9:32 ` Chaitanya Kulkarni
2023-05-07 23:09 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 08/12] nvme/rc: Add minimal test image size requirement Daniel Wagner
2023-05-03 9:35 ` Chaitanya Kulkarni
2023-05-07 23:19 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 09/12] common/fio: Limit number of random jobs Daniel Wagner
2023-05-03 9:41 ` Chaitanya Kulkarni
2023-05-03 11:01 ` Daniel Wagner
2023-05-04 5:16 ` Chaitanya Kulkarni
2023-05-04 6:07 ` Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random fio jobs Daniel Wagner
2023-05-07 23:31 ` Shinichiro Kawasaki
2023-05-10 17:14 ` Daniel Wagner
2023-05-03 8:02 ` [PATCH blktests v3 11/12] nvme/rc: Move discovery generation counter code to rc Daniel Wagner
2023-05-07 23:34 ` Shinichiro Kawasaki
2023-05-10 17:24 ` Daniel Wagner
2023-05-11 16:44 ` Shinichiro Kawasaki
2023-05-03 8:02 ` [PATCH blktests v3 12/12] nvme: Make the number iterations configurable Daniel Wagner
2023-05-03 9:45 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503080258.14525-6-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox