* [PATCH] nvme-pci: cleaning up nvme_pci_init_request
@ 2023-05-12 6:05 Irvin Cote
2023-05-15 9:54 ` Christoph Hellwig
2023-05-15 17:13 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Irvin Cote @ 2023-05-12 6:05 UTC (permalink / raw)
To: hch; +Cc: kbusch, axboe, sagi, linux-nvme, Irvin Cote
Erase the superfluous line that retrieves the nvme_dev.
Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
---
drivers/nvme/host/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7f25c0fe3a0b..b027e5e3f4ac 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -420,10 +420,9 @@ static int nvme_pci_init_request(struct blk_mq_tag_set *set,
struct request *req, unsigned int hctx_idx,
unsigned int numa_node)
{
- struct nvme_dev *dev = to_nvme_dev(set->driver_data);
struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
- nvme_req(req)->ctrl = &dev->ctrl;
+ nvme_req(req)->ctrl = set->driver_data;
nvme_req(req)->cmd = &iod->cmd;
return 0;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nvme-pci: cleaning up nvme_pci_init_request
2023-05-12 6:05 [PATCH] nvme-pci: cleaning up nvme_pci_init_request Irvin Cote
@ 2023-05-15 9:54 ` Christoph Hellwig
2023-05-15 17:13 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-05-15 9:54 UTC (permalink / raw)
To: Irvin Cote; +Cc: hch, kbusch, axboe, sagi, linux-nvme
On Fri, May 12, 2023 at 03:05:37AM -0300, Irvin Cote wrote:
> Erase the superfluous line that retrieves the nvme_dev.
>
> Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-pci: cleaning up nvme_pci_init_request
2023-05-12 6:05 [PATCH] nvme-pci: cleaning up nvme_pci_init_request Irvin Cote
2023-05-15 9:54 ` Christoph Hellwig
@ 2023-05-15 17:13 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2023-05-15 17:13 UTC (permalink / raw)
To: Irvin Cote; +Cc: hch, axboe, sagi, linux-nvme
Thanks, applied to nvme-6.5.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-15 17:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 6:05 [PATCH] nvme-pci: cleaning up nvme_pci_init_request Irvin Cote
2023-05-15 9:54 ` Christoph Hellwig
2023-05-15 17:13 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox