Re: [PATCH 2/2] nvme-fcloop: no need to return from void function

Max Gurtovoy
2023-05-21T09:57:23Z

Hi CK,

On 19/05/2023 12:40, Chaitanya Kulkarni wrote:
> Remove return at the end of void function.
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/target/fcloop.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
> index e940a7d37a9d..1ab3d900f2bf 100644
> --- a/drivers/nvme/target/fcloop.c
> +++ b/drivers/nvme/target/fcloop.c
> @@ -645,8 +645,6 @@ fcloop_fcp_recv_work(struct work_struct *work)
> }
> if (ret)
> fcloop_call_host_done(fcpreq, tfcp_req, ret);
> -
> - return;
> }
>
> static void

Looks good,

Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>

BTW, are patches 1/2 and 2/2 related to each other ?
Can you split between them please if not related.