* [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head
@ 2023-05-17 22:09 Irvin Cote
2023-05-18 9:06 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Irvin Cote @ 2023-05-17 22:09 UTC (permalink / raw)
To: hch; +Cc: kbusch, axboe, sagi, linux-nvme, Irvin Cote
nvme_find_ns_head already checks that the list of namescpaces
in an already existing namespace head is not empty
Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index ccb6eb1282f8..54a8eadd9876 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4209,7 +4209,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
goto out_put_ns_head;
}
- if (!multipath && !list_empty(&head->list)) {
+ if (!multipath) {
dev_warn(ctrl->device,
"Found shared namespace %d, but multipathing not supported.\n",
info->nsid);
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head
2023-05-17 22:09 [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head Irvin Cote
@ 2023-05-18 9:06 ` Sagi Grimberg
2023-05-19 2:29 ` Keith Busch
2023-05-20 4:39 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2023-05-18 9:06 UTC (permalink / raw)
To: Irvin Cote, hch; +Cc: kbusch, axboe, linux-nvme
> nvme_find_ns_head already checks that the list of namescpaces
> in an already existing namespace head is not empty
>
> Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index ccb6eb1282f8..54a8eadd9876 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -4209,7 +4209,7 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
> goto out_put_ns_head;
> }
>
> - if (!multipath && !list_empty(&head->list)) {
> + if (!multipath) {
> dev_warn(ctrl->device,
> "Found shared namespace %d, but multipathing not supported.\n",
> info->nsid);
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head
2023-05-17 22:09 [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head Irvin Cote
2023-05-18 9:06 ` Sagi Grimberg
@ 2023-05-19 2:29 ` Keith Busch
2023-05-19 3:31 ` irvin cote
2023-05-20 4:39 ` Christoph Hellwig
2023-05-20 4:39 ` Christoph Hellwig
2 siblings, 2 replies; 6+ messages in thread
From: Keith Busch @ 2023-05-19 2:29 UTC (permalink / raw)
To: Irvin Cote; +Cc: hch, axboe, sagi, linux-nvme
On Wed, May 17, 2023 at 07:09:15PM -0300, Irvin Cote wrote:
> - if (!multipath && !list_empty(&head->list)) {
> + if (!multipath) {
> dev_warn(ctrl->device,
> "Found shared namespace %d, but multipathing not supported.\n",
> info->nsid);
> --
Thanks, applied for nvme-6.5.
Side note, the very next print says this path was to be removed by 6.0,
so we're a little late on that. Did you actually hit this condition or
found it from inspection?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head
2023-05-19 2:29 ` Keith Busch
@ 2023-05-19 3:31 ` irvin cote
2023-05-20 4:39 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: irvin cote @ 2023-05-19 3:31 UTC (permalink / raw)
To: Keith Busch; +Cc: hch, axboe, sagi, linux-nvme
I found it from inspection
On Thu, 18 May 2023 at 23:29, Keith Busch <kbusch@kernel.org> wrote:
>
> On Wed, May 17, 2023 at 07:09:15PM -0300, Irvin Cote wrote:
> > - if (!multipath && !list_empty(&head->list)) {
> > + if (!multipath) {
> > dev_warn(ctrl->device,
> > "Found shared namespace %d, but multipathing not supported.\n",
> > info->nsid);
> > --
>
> Thanks, applied for nvme-6.5.
>
> Side note, the very next print says this path was to be removed by 6.0,
> so we're a little late on that. Did you actually hit this condition or
> found it from inspection?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head
2023-05-19 2:29 ` Keith Busch
2023-05-19 3:31 ` irvin cote
@ 2023-05-20 4:39 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2023-05-20 4:39 UTC (permalink / raw)
To: Keith Busch; +Cc: Irvin Cote, hch, axboe, sagi, linux-nvme
On Thu, May 18, 2023 at 08:29:39PM -0600, Keith Busch wrote:
> On Wed, May 17, 2023 at 07:09:15PM -0300, Irvin Cote wrote:
> > - if (!multipath && !list_empty(&head->list)) {
> > + if (!multipath) {
> > dev_warn(ctrl->device,
> > "Found shared namespace %d, but multipathing not supported.\n",
> > info->nsid);
> > --
>
> Thanks, applied for nvme-6.5.
>
> Side note, the very next print says this path was to be removed by 6.0,
> so we're a little late on that.
Yeah, I need to get to this and the resulting cleanup. Hopefully I'll
find some time the next weeks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head
2023-05-17 22:09 [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head Irvin Cote
2023-05-18 9:06 ` Sagi Grimberg
2023-05-19 2:29 ` Keith Busch
@ 2023-05-20 4:39 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2023-05-20 4:39 UTC (permalink / raw)
To: Irvin Cote; +Cc: hch, kbusch, axboe, sagi, linux-nvme
On Wed, May 17, 2023 at 07:09:15PM -0300, Irvin Cote wrote:
> nvme_find_ns_head already checks that the list of namescpaces
> in an already existing namespace head is not empty
>
> Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-20 4:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 22:09 [PATCH 1/1] nvme-core : remove redundant check from nvme_init_ns_head Irvin Cote
2023-05-18 9:06 ` Sagi Grimberg
2023-05-19 2:29 ` Keith Busch
2023-05-19 3:31 ` irvin cote
2023-05-20 4:39 ` Christoph Hellwig
2023-05-20 4:39 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox