From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: hare@suse.de, linux-nvme@lists.infradead.org, hch@lst.de,
sagi@grimberg.me
Subject: Re: [PATCH 2/3] nvme-fabrics: error out when connect I/O fails
Date: Tue, 23 May 2023 08:58:42 +0200 [thread overview]
Message-ID: <20230523065842.GB8533@lst.de> (raw)
In-Reply-To: <20230522130408.105328-3-kch@nvidia.com>
On Mon, May 22, 2023 at 06:04:07AM -0700, Chaitanya Kulkarni wrote:
> In nvmf_connect_io_queue() when connect I/O commands fails we just
> log the connect error and continue processing for authentication.
>
> Add goto out_free_data after logging the connect error to error out.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-05-23 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 13:04 [PATCH 0/3] nvme-fabrics: auth fixes and cleanup Chaitanya Kulkarni
2023-05-22 13:04 ` [PATCH 1/3] nvme-fabrics: fix qid in error message Chaitanya Kulkarni
2023-05-23 6:58 ` Christoph Hellwig
2023-05-22 13:04 ` [PATCH 2/3] nvme-fabrics: error out when connect I/O fails Chaitanya Kulkarni
2023-05-23 6:58 ` Christoph Hellwig [this message]
2023-05-22 13:04 ` [PATCH 3/3] nvme-fabrics: factor out common for auth Chaitanya Kulkarni
2023-05-23 7:00 ` Christoph Hellwig
2023-05-23 8:31 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523065842.GB8533@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox