public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Uday Shankar <ushankar@purestorage.com>
To: Costa Sapuntzakis <costa@purestorage.com>,
	Randy Jennings <randyj@purestorage.com>,
	Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@fb.com>
Cc: Uday Shankar <ushankar@purestorage.com>, linux-nvme@lists.infradead.org
Subject: [PATCH v6 0/3] keepalive bugfixes
Date: Thu, 25 May 2023 12:22:01 -0600	[thread overview]
Message-ID: <20230525182204.1954429-1-ushankar@purestorage.com> (raw)

While reviewing the Linux KATO implementation in an attempt to better
understand the current NVMe Keep Alive specification, we found a
few issues in the host implementation that could contribute to spurious
Keep Alive timeouts being detected by controllers.

Changes v5-v6 (https://lore.kernel.org/linux-nvme/20230524232218.1584605-1-ushankar@purestorage.com/):
- Patch 2: fix line length and extra empty line, add comment about
  	   req->deadline - req->timeout

Changes v4-v5 (https://lore.kernel.org/linux-nvme/20230524193809.1360269-1-ushankar@purestorage.com/):
- Patch 2: revert changes to start_time; use req->deadline -
           req->timeout instead

Changes v3-v4 (https://lore.kernel.org/linux-nvme/20230518183311.3224326-1-ushankar@purestorage.com/):
- Patch 1: fix style, improve readability, include helper from patch 3
- Patch 2: refactor to remove need for WRITE_ONCE/barriers
- Patch 3: fix comment style, move helper to patch 1

Changes v2-v3 (https://lore.kernel.org/linux-nvme/20230424232225.1975793-1-ushankar@purestorage.com/):
- Patch 3: add a warning log line for long keepalive RTT

Changes v1-v2 (https://lore.kernel.org/linux-nvme/20230417225558.2890062-1-ushankar@purestorage.com/):
- Patch 2: fix indentation, set start_time even when stats disabled

Uday Shankar (3):
  nvme: double KA polling frequency to avoid KATO with TBKAS on
  nvme: check IO start time when deciding to defer KA
  nvme: improve handling of long keep alives

 drivers/nvme/host/core.c | 48 +++++++++++++++++++++++++++++++++++++---
 drivers/nvme/host/nvme.h |  1 +
 2 files changed, 46 insertions(+), 3 deletions(-)

-- 
2.25.1



             reply	other threads:[~2023-05-25 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 18:22 Uday Shankar [this message]
2023-05-25 18:22 ` [PATCH v6 1/3] nvme: double KA polling frequency to avoid KATO with TBKAS on Uday Shankar
2023-05-25 18:22 ` [PATCH v6 2/3] nvme: check IO start time when deciding to defer KA Uday Shankar
2023-05-26  7:55   ` Christoph Hellwig
2023-05-25 18:22 ` [PATCH v6 3/3] nvme: improve handling of long keep alives Uday Shankar
2023-05-30 16:21 ` [PATCH v6 0/3] keepalive bugfixes Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525182204.1954429-1-ushankar@purestorage.com \
    --to=ushankar@purestorage.com \
    --cc=axboe@fb.com \
    --cc=costa@purestorage.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=randyj@purestorage.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox