public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Irvin Cote <irvincoteg@gmail.com>
To: hch@lst.de
Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, Irvin Cote <irvincoteg@gmail.com>
Subject: [PATCH 2/3] nvme-core: exit scan if shared ns but no multipath
Date: Tue, 30 May 2023 19:27:08 -0300	[thread overview]
Message-ID: <20230530222709.28682-3-irvincoteg@gmail.com> (raw)
In-Reply-To: <20230530222709.28682-1-irvincoteg@gmail.com>

If a shared namespace is found during a scan but with multipathing not
enabled, inform the user that the driver must be built with
CONFIG_NVME_MULTIPATH and exit.

Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
---
 drivers/nvme/host/core.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 2f89477e4878..6aa160529887 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3565,10 +3565,11 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
 
 		if (!multipath) {
 			dev_warn(ctrl->device,
-				"Found shared namespace %d, but multipathing not supported.\n",
+				"Found shared namespace %d, but multipathing not supported.
+				 Enable CONFIG_BLK_MULTIPATH when building to support
+				 shared namespaces\n",
 				info->nsid);
-			dev_warn_once(ctrl->device,
-				"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n.");
+			goto out_put_ns_head;
 		}
 	}
 
-- 
2.40.1



  parent reply	other threads:[~2023-05-30 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 22:27 [PATCH 0/3] Start to disable shared ns without multipating Irvin Cote
2023-05-30 22:27 ` [PATCH 1/3] nvme-Kconfig: updating MULTIPATH option's description Irvin Cote
2023-05-30 22:27 ` Irvin Cote [this message]
2023-05-30 22:27 ` [PATCH 3/3] nvme-core: changing comment on disk names in nvme_alloc_ns Irvin Cote

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230530222709.28682-3-irvincoteg@gmail.com \
    --to=irvincoteg@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox