From: Irvin Cote <irvincoteg@gmail.com>
To: hch@lst.de
Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, Irvin Cote <irvincoteg@gmail.com>
Subject: [PATCH 3/3] nvme-core: changing comment on disk names in nvme_alloc_ns
Date: Tue, 30 May 2023 19:27:09 -0300 [thread overview]
Message-ID: <20230530222709.28682-4-irvincoteg@gmail.com> (raw)
In-Reply-To: <20230530222709.28682-1-irvincoteg@gmail.com>
The comment was mentioning the name of shared namespaces when
multipathing wasn't enabled, but we don't support shared namespaces
without multipathing anymore.
Signed-off-by: Irvin Cote <irvincoteg@gmail.com>
---
drivers/nvme/host/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 6aa160529887..197a30a59c99 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3661,9 +3661,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
* namespaces could lead to naming collisions between shared and private
* namespaces if they don't use a common numbering scheme.
*
- * If multipathing is not enabled, disk names must use the controller
- * instance as shared namespaces will show up as multiple block
- * devices.
+ * If multipathing is not enabled, we only have private namespaces and
+ * disk names use the controller instance.
*/
if (ns->head->disk) {
sprintf(disk->disk_name, "nvme%dc%dn%d", ctrl->subsys->instance,
--
2.40.1
prev parent reply other threads:[~2023-05-30 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 22:27 [PATCH 0/3] Start to disable shared ns without multipating Irvin Cote
2023-05-30 22:27 ` [PATCH 1/3] nvme-Kconfig: updating MULTIPATH option's description Irvin Cote
2023-05-30 22:27 ` [PATCH 2/3] nvme-core: exit scan if shared ns but no multipath Irvin Cote
2023-05-30 22:27 ` Irvin Cote [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530222709.28682-4-irvincoteg@gmail.com \
--to=irvincoteg@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox