public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Uday Shankar <ushankar@purestorage.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-nvme@lists.infradead.org,
	Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>,
	Christoph Hellwig <hch@lst.de>
Subject: [linux-nvme:nvme-6.4-rc4-pull 5/5] drivers/nvme/host/core.c:1202:51: error: 'struct nvme_request' has no member named 'start_time'
Date: Wed, 31 May 2023 05:27:59 +0800	[thread overview]
Message-ID: <202305310532.V3y3hWXI-lkp@intel.com> (raw)

tree:   git://git.infradead.org/nvme.git nvme-6.4-rc4-pull
head:   f041d3b83aea7e76e4dfc6591954d6dfe506dbdb
commit: f041d3b83aea7e76e4dfc6591954d6dfe506dbdb [5/5] nvme: improve handling of long keep alives
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20230531/202305310532.V3y3hWXI-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add linux-nvme git://git.infradead.org/nvme.git
        git fetch --no-tags linux-nvme nvme-6.4-rc4-pull
        git checkout f041d3b83aea7e76e4dfc6591954d6dfe506dbdb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/nvme/host/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305310532.V3y3hWXI-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/nvme/host/core.c: In function 'nvme_keep_alive_end_io':
>> drivers/nvme/host/core.c:1202:51: error: 'struct nvme_request' has no member named 'start_time'
    1202 |         unsigned long rtt = jiffies - nvme_req(rq)->start_time;
         |                                                   ^~


vim +1202 drivers/nvme/host/core.c

  1195	
  1196	static enum rq_end_io_ret nvme_keep_alive_end_io(struct request *rq,
  1197							 blk_status_t status)
  1198	{
  1199		struct nvme_ctrl *ctrl = rq->end_io_data;
  1200		unsigned long flags;
  1201		bool startka = false;
> 1202		unsigned long rtt = jiffies - nvme_req(rq)->start_time;
  1203		unsigned long delay = nvme_keep_alive_work_period(ctrl);
  1204	
  1205		/*
  1206		 * Subtract off the keepalive RTT so nvme_keep_alive_work runs
  1207		 * at the desired frequency.
  1208		 */
  1209		if (rtt <= delay) {
  1210			delay -= rtt;
  1211		} else {
  1212			dev_warn(ctrl->device, "long keepalive RTT (%u ms)\n",
  1213				 jiffies_to_msecs(rtt));
  1214			delay = 0;
  1215		}
  1216	
  1217		blk_mq_free_request(rq);
  1218	
  1219		if (status) {
  1220			dev_err(ctrl->device,
  1221				"failed nvme_keep_alive_end_io error=%d\n",
  1222					status);
  1223			return RQ_END_IO_NONE;
  1224		}
  1225	
  1226		ctrl->ka_last_check_time = jiffies;
  1227		ctrl->comp_seen = false;
  1228		spin_lock_irqsave(&ctrl->lock, flags);
  1229		if (ctrl->state == NVME_CTRL_LIVE ||
  1230		    ctrl->state == NVME_CTRL_CONNECTING)
  1231			startka = true;
  1232		spin_unlock_irqrestore(&ctrl->lock, flags);
  1233		if (startka)
  1234			queue_delayed_work(nvme_wq, &ctrl->ka_work, delay);
  1235		return RQ_END_IO_NONE;
  1236	}
  1237	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


             reply	other threads:[~2023-05-30 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 21:27 kernel test robot [this message]
2023-05-31  0:08 ` [linux-nvme:nvme-6.4-rc4-pull 5/5] drivers/nvme/host/core.c:1202:51: error: 'struct nvme_request' has no member named 'start_time' Uday Shankar
2023-05-31  4:01   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202305310532.V3y3hWXI-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=ushankar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox