From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org,
axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
kernel test robot <lkp@intel.com>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] nvme-fabrics: error out to unlock the mutex
Date: Fri, 2 Jun 2023 17:03:15 +0200 [thread overview]
Message-ID: <20230602150315.GA25353@lst.de> (raw)
In-Reply-To: <20230602053713.43006-1-kch@nvidia.com>
On Thu, Jun 01, 2023 at 10:37:13PM -0700, Chaitanya Kulkarni wrote:
> host = nvmf_host_alloc(hostnqn, id);
> - if (!host)
> - return ERR_PTR(-ENOMEM);
> + if (!host) {
> + host = ERR_PTR(-ENOMEM);
> + goto out_unlock;
> + }
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-02 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 5:37 [PATCH] nvme-fabrics: error out to unlock the mutex Chaitanya Kulkarni
2023-06-02 5:42 ` Julia Lawall
2023-06-02 15:03 ` Christoph Hellwig [this message]
2023-06-04 0:38 ` Max Gurtovoy
2023-06-05 22:40 ` Sagi Grimberg
2023-06-09 15:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602150315.GA25353@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=julia.lawall@inria.fr \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox